From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
mturquette@baylibre.com, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Dmitry Torokhov <dtor@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
open list <linux-kernel@vger.kernel.org>,
Nishanth Menon <nm@ti.com>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex
Date: Wed, 4 Nov 2015 14:11:25 -0800 [thread overview]
Message-ID: <20151104221125.GU19782@codeaurora.org> (raw)
In-Reply-To: <5f8fac4ad84716ef68fc50ab0b78e11ad2837524.1446205160.git.viresh.kumar@linaro.org>
On 10/30, Viresh Kumar wrote:
> dev_opp_list_lock is used everywhere to protect device and OPP lists,
> but dev_pm_opp_set_sharing_cpus() is missed somehow. And instead we used
> rcu-lock, which wouldn't help here as we are adding a new list_dev.
>
> This also fixes a problem where we have called kzalloc(..., GFP_KERNEL)
> from within rcu-lock, which isn't allowed as kzalloc can sleep when
> called with GFP_KERNEL.
>
> With CONFIG_DEBUG_ATOMIC_SLEEP set, we will see the caller vomiting.
>
> Fixes: 8d4d4e98acd6 ("PM / OPP: Add helpers for initializing CPU OPPs")
> Reported-by: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
I assume some other patch will come to fix the comment and/or add
the lockdep check.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-11-04 22:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 11:56 [PATCH] PM / OPP: Protect updates to list_dev with mutex Viresh Kumar
2015-10-30 11:56 ` Viresh Kumar
2015-10-30 12:04 ` Dan Carpenter
2015-10-30 12:40 ` [PATCH] PM / OPP: Propagate error properly from dev_pm_opp_set_sharing_cpus() Viresh Kumar
2015-10-30 12:40 ` Viresh Kumar
2015-10-30 20:59 ` Stephen Boyd
2015-10-30 17:06 ` [PATCH] PM / OPP: Protect updates to list_dev with mutex Stephen Boyd
2015-10-31 2:14 ` Viresh Kumar
2015-11-02 19:14 ` Stephen Boyd
2015-11-04 2:19 ` Viresh Kumar
2015-11-05 8:42 ` Viresh Kumar
2015-11-04 10:22 ` Michael Turquette
2015-11-04 10:25 ` Viresh Kumar
2015-11-04 22:11 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104221125.GU19782@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=dtor@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.