From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: James Bottomley <jbottomley@parallels.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/2] Separate target visibility from reaped state information
Date: Thu, 5 Nov 2015 09:50:23 +0100 [thread overview]
Message-ID: <20151105085023.GA20249@lst.de> (raw)
In-Reply-To: <5633EA4C.10608@sandisk.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
A few things I noticed when looking over this and the previous iterations,
which are more notes for future work than an actual comment on this patch:
- what lock protects ->visible and ->reaped (or previously ->state)?
It seems like the synchronization rules in this code are a little
fragile.
- why don't we make the target visible as soon as we allocated it?
We can still tear it down without a whole more effort even if it is
visible.
next prev parent reply other threads:[~2015-11-05 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 22:06 [PATCH 0/2] Fix a hard lockup in scsi_remove_target() Bart Van Assche
2015-10-30 22:08 ` [PATCH 1/2] Separate target visibility from reaped state information Bart Van Assche
2015-11-05 8:50 ` Christoph Hellwig [this message]
2015-10-30 22:09 ` [PATCH 2/2] Restart list search after unlock in scsi_remove_target Bart Van Assche
2015-11-04 22:35 ` Bart Van Assche
2015-11-04 22:44 ` James Bottomley
2015-11-04 23:20 ` Bart Van Assche
2015-11-16 17:57 ` Christoph Hellwig
2015-11-05 16:55 ` Dan Williams
2015-11-05 17:05 ` James Bottomley
2015-11-05 8:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105085023.GA20249@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@sandisk.com \
--cc=dan.j.williams@intel.com \
--cc=jbottomley@parallels.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.