All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] IB/mlx: Expose max_fmr to ib_query_device
Date: Thu, 5 Nov 2015 12:48:45 +0200	[thread overview]
Message-ID: <20151105104844.GA7749@yuval-lab> (raw)
In-Reply-To: <563255A9.1050705-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>

On Thu, Oct 29, 2015 at 07:21:45PM +0200, Sagi Grimberg wrote:
> Hi Yuval,
> 
> The title prefix should be IB/mlx4:
> 
> >Expose max_fmr so it will be available to ULPs.
> >max_fmr is num_mpts minus reserved.
> >
> >Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> >---
> >  drivers/infiniband/hw/mlx4/main.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
> >index efecdf0..4f9ff35 100644
> >--- a/drivers/infiniband/hw/mlx4/main.c
> >+++ b/drivers/infiniband/hw/mlx4/main.c
> >@@ -475,6 +475,7 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
> >  	props->max_mcast_qp_attach = dev->dev->caps.num_qp_per_mgm;
> >  	props->max_total_mcast_qp_attach = props->max_mcast_qp_attach *
> >  					   props->max_mcast_grp;
> >+	props->max_fmr = dev->dev->caps.num_mpts - dev->dev->caps.reserved_mrws;
> 
> Umm, this looks like a capability that needs to communicated from the
> device. Perhaps this needs to be added to CX3 FW? Or?
Mellanox folks, can you review this driver change?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-11-05 10:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 16:07 [PATCH] IB/mlx: Expose max_fmr to ib_query_device Yuval Shaia
     [not found] ` <1446134879-20456-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-10-29 17:21   ` Sagi Grimberg
     [not found]     ` <563255A9.1050705-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-05 10:48       ` Yuval Shaia [this message]
2015-11-05 10:51         ` Christoph Hellwig
     [not found]           ` <20151105105128.GA24381-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-05 11:07             ` Yuval Shaia
2015-11-05 11:10               ` Christoph Hellwig
     [not found]                 ` <20151105111035.GA25203-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-05 12:12                   ` Yuval Shaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105104844.GA7749@yuval-lab \
    --to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.