From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>
Cc: devel@driverdev.osuosl.org, linux-rdma@vger.kernel.org,
gregkh@linuxfoundation.org, jubin.john@intel.com,
dledford@redhat.com,
Sebastian Sanchez <sebastian.sanchez@intel.com>
Subject: Re: [PATCH] staging/rdma/hfi1: Convert dd_dev_info() to hfi1_cdbg() in process startup
Date: Thu, 5 Nov 2015 17:53:34 +0300 [thread overview]
Message-ID: <20151105145334.GY18797@mwanda> (raw)
In-Reply-To: <20151105145119.GA16285@phlsvsds.ph.intel.com>
On Thu, Nov 05, 2015 at 09:51:20AM -0500, Dennis Dalessandro wrote:
> >/me chants, "delete. delete. delete."
>
> I would tend to agree with that, but in this case we want to keep a
> way to get this information without making code changes. We just
> don't want it to spew to the console/syslog all the time. Instead we
> are using the trace mechanism which lets the user selectively turn
> on the messages when needed.
>
> Perhaps we should expand on the commit message to make this more clear?
>
No no. It's fine. So long as you aren't just keeping it around because
you are afraid to delete things.
regards,
dan carpenter
prev parent reply other threads:[~2015-11-05 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 4:14 [PATCH] staging/rdma/hfi1: Convert dd_dev_info() to hfi1_cdbg() in process startup jubin.john-ral2JQCrhuEAvxtiuMwx3w
2015-11-05 7:58 ` Dan Carpenter
2015-11-05 14:51 ` Dennis Dalessandro
2015-11-05 14:53 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105145334.GY18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dennis.dalessandro@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jubin.john@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sebastian.sanchez@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.