From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 07/13] drm/i915: don't disable_fbc() if FBC is already disabled
Date: Thu, 5 Nov 2015 17:52:43 +0200 [thread overview]
Message-ID: <20151105155243.GK4437@intel.com> (raw)
In-Reply-To: <563B6D2F.5040704@linux.intel.com>
On Thu, Nov 05, 2015 at 03:52:31PM +0100, Maarten Lankhorst wrote:
> Hey,
>
> Op 05-11-15 om 12:29 schreef Ville Syrjälä:
> > On Wed, Nov 04, 2015 at 05:10:51PM -0200, Paulo Zanoni wrote:
> >> If FBC is disabled we will still call intel_fbc_invalidate(), and as a
> >> result we may call intel_fbc_deactivate(), which will try to touch
> >> registers.
> >>
> >> I'm pretty sure I saw this happen on a runtime suspended device, and
> > This is one of the BAT failures we have. I don't really understand why
> > we track the frontbuffer bits with FBC totally disabled, but this fix
> > seems simple enough on its own. Not sure if it applies without the
> > others, but if it doesn't I suggest trying to reorder the patchset so
> > we can put this in ASAP.
> >
> For the commit message what BAT is affected?
/me looks
pm_rpm@basic-rte at least.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-05 15:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 19:10 [PATCH 00/13] Yet another FBC series, v3 part 1 Paulo Zanoni
2015-11-04 19:10 ` [PATCH 01/13] drm/i915: rename intel_fbc_nuke to intel_fbc_recompress Paulo Zanoni
2015-11-04 19:10 ` [PATCH 02/13] drm/i915: extract fbc_on_pipe_a_only() Paulo Zanoni
2015-11-04 19:10 ` [PATCH 03/13] drm/i915: remove unnecessary check for crtc->primary->fb Paulo Zanoni
2015-11-04 19:10 ` [PATCH 04/13] drm/i915: extract crtc_is_valid() on the FBC code Paulo Zanoni
2015-11-04 19:10 ` [PATCH 05/13] drm/i915: use struct intel_crtc *crtc at __intel_fbc_update() Paulo Zanoni
2015-11-04 19:10 ` [PATCH 06/13] drm/i915: fix the __intel_fbc_update() comments Paulo Zanoni
2015-11-04 19:10 ` [PATCH 07/13] drm/i915: don't disable_fbc() if FBC is already disabled Paulo Zanoni
2015-11-05 11:29 ` Ville Syrjälä
2015-11-05 14:52 ` Maarten Lankhorst
2015-11-05 15:52 ` Ville Syrjälä [this message]
2015-11-04 19:10 ` [PATCH 08/13] drm/i915: refactor FBC deactivation at init Paulo Zanoni
2015-11-04 19:10 ` [PATCH 09/13] drm/i915: remove too-frequent FBC debug message Paulo Zanoni
2015-11-04 19:10 ` [PATCH 10/13] drm/i915: fix the CFB size check Paulo Zanoni
2015-11-10 10:22 ` Maarten Lankhorst
2015-11-10 12:20 ` Zanoni, Paulo R
2015-11-10 13:04 ` Maarten Lankhorst
2015-11-11 13:39 ` Zanoni, Paulo R
2015-11-11 14:25 ` Maarten Lankhorst
2015-11-11 14:27 ` Ville Syrjälä
2015-11-11 15:36 ` Zanoni, Paulo R
2015-11-04 19:10 ` [PATCH 11/13] drm/i915: clarify that checking the FB stride for CFB is intentional Paulo Zanoni
2015-11-04 19:10 ` [PATCH 12/13] drm/i915: remove in_dbg_master check from intel_fbc.c Paulo Zanoni
2015-11-04 20:13 ` Jesse Barnes
2015-11-04 20:19 ` Jason Wessel
2015-11-04 20:26 ` Zanoni, Paulo R
2015-11-04 20:32 ` Jesse Barnes
2015-11-04 19:10 ` [PATCH 13/13] drm/i915: remove newline from a no_fbc_reason message Paulo Zanoni
2015-11-13 15:49 ` [PATCH 00/13] Yet another FBC series, v3 part 1 Daniel Stone
2015-11-13 16:36 ` Zanoni, Paulo R
2015-11-13 16:58 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105155243.GK4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.