From: Dan Carpenter <dan.carpenter@oracle.com>
To: "ira.weiny" <ira.weiny@intel.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
dledford@redhat.com, Dean Luick <dean.luick@intel.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices
Date: Thu, 5 Nov 2015 21:42:58 +0300 [thread overview]
Message-ID: <20151105184258.GM7289@mwanda> (raw)
In-Reply-To: <20151105164121.GA14837@phlsvsds.ph.intel.com>
On Thu, Nov 05, 2015 at 11:41:23AM -0500, ira.weiny wrote:
> Is this an example where we should ignore the line lengths of checkpatch to
> preserve the readability of the code?
Honestly, you can't fight checkpatch, especially in staging. Rejecting
patches is a drain on your emotions and your energy. We accept all
checkpatch fixes if they are half way decent.
Maybe just put a comment in the header about the full hardware name?
This patch breaks cscope and we don't end up actually using the hardware
name in the end...
regards,
dan carpenter
prev parent reply other threads:[~2015-11-05 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 2:06 [PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-11-05 7:34 ` Dan Carpenter
2015-11-05 16:41 ` ira.weiny
2015-11-05 18:42 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105184258.GM7289@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dean.luick@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.