From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751593AbbKETVP (ORCPT ); Thu, 5 Nov 2015 14:21:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51104 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbbKETVO (ORCPT ); Thu, 5 Nov 2015 14:21:14 -0500 Date: Thu, 5 Nov 2015 21:17:20 +0100 From: Oleg Nesterov To: Andrew Morton , Dmitry Vyukov Cc: Roland McGrath , amanieu@gmail.com, pmoore@redhat.com, Ingo Molnar , vdavydov@parallels.com, qiaowei.ren@intel.com, dave@stgolabs.net, palmer@dabbelt.com, syzkaller , Kostya Serebryany , Alexander Potapenko , Sasha Levin , linux-kernel@vger.kernel.org Subject: [PATCH 0/3] signal: kill the obsolete SIGNAL_UNKILLABLE check in complete_signal() Message-ID: <20151105201720.GA15763@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/05, Oleg Nesterov wrote: > > Cough... and on the second thought this patch needs v2. Sorry Andrew, please > drop signal-kill-the-obsolete-signal_unkillable-check-in-complete_signal.patch > I'll send the updated version. > > With this patch the parent namespace can use any fatal signal (not only SIGKILL) > to kill the init process in container. I do not think this is actually bad, but > in any case this should not silently come as a side effect. And this is not > consistent with SIGNAL_UNKILLABLE/sig_kernel_only() check in get_signal(). > > Most probably I will just resend this patch as 2/2, while 1/2 will change > sig_task_ignored() because afaics it is not actually right too (albeit not > really buggy). So this replaces signal-kill-the-obsolete-signal_unkillable-check-in-complete_signal.patch 2/3 is actually the same change, just the changelog was updated. I'll try to send the cleanups tomorrow. sig_task_ignored() doesn't look nice, sig_handler_ignored() must die, SIGNAL_UNKILLABLE checks in sig_task_ignored() and get_signal() should be unified. And to remind, we need to fix more problems I found yesterday. Oleg.