From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zudb3-0005pv-Sk for qemu-devel@nongnu.org; Fri, 06 Nov 2015 04:46:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zudb3-0001ii-2w for qemu-devel@nongnu.org; Fri, 06 Nov 2015 04:46:13 -0500 Date: Fri, 6 Nov 2015 10:46:05 +0100 From: Kevin Wolf Message-ID: <20151106094605.GC4071@noname.redhat.com> References: <1446767584-13132-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446767584-13132-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/3] qemu-io: clean up cvtnum usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com Am 06.11.2015 um 00:53 hat John Snow geschrieben: > cvtnum returns an int64_t, not an int, so correct the lvalue types > wherever it is used. While we're at it, make the error messages more > meaningful and hopefully less confusing. > > v4: > - Now missing ALL sweaters > > v3: > - pulled a lot of loose yarn, now missing my sweater > (Updated patch 1 even further, reported-by Kevin) > > v2: > - Squashed NSIG error-checking from patch 3 into patch 1 > - Reported-by credits for Max and Reviewed-by from Eric added Thanks, applied to the block branch. (Should we mention in the changelog that qemu 2.5 contains some of your sweaters?) Kevin