From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 1/2] src: allow filtering on L2 header in inet family
Date: Fri, 6 Nov 2015 14:31:41 +0100 [thread overview]
Message-ID: <20151106133141.GA6142@salvia> (raw)
In-Reply-To: <1443237243-4571-1-git-send-email-fw@strlen.de>
On Sat, Sep 26, 2015 at 05:14:02AM +0200, Florian Westphal wrote:
> Error: conflicting protocols specified: inet vs. ether
> tcp dport 22 iiftype ether ether saddr 00:0f:54:0c:11:4
> ^^^^^^^^^^^
>
> This allows the implicit inet proto dependency to get replaced
> by an ethernet one.
>
> This is possible since by the time we detect the conflict the
> meta dependency for the network protocol has already been added.
>
> So we only need to add another dependency on the Linklayer frame type.
>
> Closes: http://bugzilla.netfilter.org/show_bug.cgi?id=981
> Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
P.S: You push this Florian, thanks.
prev parent reply other threads:[~2015-11-06 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 3:14 [PATCH nft 1/2] src: allow filtering on L2 header in inet family Florian Westphal
2015-09-26 3:14 ` [PATCH nft 2/2] rule: don't reorder protocol payload expressions when merging Florian Westphal
2015-10-06 10:33 ` Florian Westphal
2015-11-06 13:35 ` Pablo Neira Ayuso
2015-11-06 13:31 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106133141.GA6142@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.