From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161578AbbKFNgY (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Nov 2015 08:36:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33049 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1161510AbbKFNgW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Nov 2015 08:36:22 -0500
Date: Fri, 6 Nov 2015 15:32:29 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dmitry Vyukov <dvyukov@google.com>, Roland McGrath <roland@hack.frob.com>,
        amanieu@gmail.com, pmoore@redhat.com, Ingo Molnar <mingo@kernel.org>,
        vdavydov@parallels.com, qiaowei.ren@intel.com, dave@stgolabs.net,
        palmer@dabbelt.com, syzkaller <syzkaller@googlegroups.com>,
        Kostya Serebryany <kcc@google.com>,
        Alexander Potapenko <glider@google.com>,
        Sasha Levin <sasha.levin@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] signal: kill the obsolete SIGNAL_UNKILLABLE check
	in complete_signal()
Message-ID: <20151106143229.GC18528@redhat.com>
References: <20151105201720.GA15763@redhat.com> <20151105153346.af4c6ed1d1fd9eec7820d634@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151105153346.af4c6ed1d1fd9eec7820d634@linux-foundation.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/05, Andrew Morton wrote:
>
> On Thu, 5 Nov 2015 21:17:20 +0100 Oleg Nesterov <oleg@redhat.com> wrote:
>
> > On 11/05, Oleg Nesterov wrote:
> > >
> > > Cough... and on the second thought this patch needs v2. Sorry Andrew, please
> > > drop signal-kill-the-obsolete-signal_unkillable-check-in-complete_signal.patch
> > > I'll send the updated version.
> > >
> > > With this patch the parent namespace can use any fatal signal (not only SIGKILL)
> > > to kill the init process in container. I do not think this is actually bad, but
> > > in any case this should not silently come as a side effect. And this is not
> > > consistent with SIGNAL_UNKILLABLE/sig_kernel_only() check in get_signal().
> > >
> > > Most probably I will just resend this patch as 2/2, while 1/2 will change
> > > sig_task_ignored() because afaics it is not actually right too (albeit not
> > > really buggy).
> >
> > So this replaces
> > signal-kill-the-obsolete-signal_unkillable-check-in-complete_signal.patch
> > 2/3 is actually the same change, just the changelog was updated.
>
> It's awfully late.  Do you see any reason why we should jam this into 4.4?

No, I think this can wait till 4.5.

Oleg.