From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 6 Nov 2015 16:35:10 -0800 From: Maxime Ripard To: Jonathan Liu Cc: Mike Turquette , Stephen Boyd , David Airlie , Thierry Reding , devicetree , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, Laurent Pinchart , Chen-Yu Tsai , Hans de Goede , Alexander Kaplan , Wynter Woods , Boris Brezillon , Thomas Petazzoni , Rob Clark , Daniel Vetter Subject: Re: [linux-sunxi] [PATCH 11/19] drm: sun4i: Add composite output Message-ID: <20151107003510.GR6114@lukather> References: <1446214865-3972-1-git-send-email-maxime.ripard@free-electrons.com> <1446214865-3972-12-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dUQzTuC3g77BtMOt" In-Reply-To: List-ID: --dUQzTuC3g77BtMOt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 02, 2015 at 01:53:20PM +1100, Jonathan Liu wrote: > > + ret =3D sun4i_tv_init(drm); > > + if (ret) { > > + dev_err(drm->dev, "Couldn't create our RGB output\n"); >=20 > RGB should be composite. Seems like a copy-paste error. Good catch. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --dUQzTuC3g77BtMOt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWPUc+AAoJEBx+YmzsjxAg2ngP/RPn1VMn5f5NHBCyQ04J/CU9 ZDQ2BQ7cYDZT0JTk6VdkbMmJbiwkTB8+z7YZeEZhi4gorHwk+NGLrYSZyvIHcZlC PjAsh93S7F77jFkmm//fkRcZ7NpWH6oivgtV3gR3/ueGdobfQfPg5vhVbRru6gWc INxnvanFIMOJtHjjzRLsedZp5N/5JrJOAcEc1v66Nated1Ms0KtP+rS0aM8Q4yJ5 SOaIVo9Cb5BPlKMjPLoYcvkf0lNkqzRxPbFnyyx9XjbFr4ZO5W0ydgkrvmYxDjHS PT1UjPbBEuB3hzhSfD3kKMEqepdW7/na+SGJk/Z3cz9Ew6I1VyrPv0Z6tscrCLYC MZ8vEeLNHi1Ia40yQ9TV9ZhwZKs+k2vYJ1u6F1TxT5H36xVeXP48wO3qUOG70Gq5 UZoltj4dCjcpvrJFJSRGWI/Lr7ulHys7/gVXud0uz6ObEGuAFgLdeFt5ixbAYoYi ZX1FeuWGSH7jXCAbF7BQE+cYO7sLkmA5N12mGhp95+0RZnN81S2b2PP7HVycOpcr 3JCoOchQZTLWNNw4VM05hyI60IGzp1VrTy5MckDAokVRPaNwSD4itVocX7bwKczZ KkDJ5E6xqhei9RXSzo+BVIIdG2Ab/TYpqenzfhXuHVOo0Fw0AU+NY5Sal2a4vRRg 1ly7qmUCs984Ql8H6Otj =Sf+z -----END PGP SIGNATURE----- --dUQzTuC3g77BtMOt-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Fri, 6 Nov 2015 16:35:10 -0800 Subject: [linux-sunxi] [PATCH 11/19] drm: sun4i: Add composite output In-Reply-To: References: <1446214865-3972-1-git-send-email-maxime.ripard@free-electrons.com> <1446214865-3972-12-git-send-email-maxime.ripard@free-electrons.com> Message-ID: <20151107003510.GR6114@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Nov 02, 2015 at 01:53:20PM +1100, Jonathan Liu wrote: > > + ret = sun4i_tv_init(drm); > > + if (ret) { > > + dev_err(drm->dev, "Couldn't create our RGB output\n"); > > RGB should be composite. Seems like a copy-paste error. Good catch. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 11/19] drm: sun4i: Add composite output Date: Fri, 6 Nov 2015 16:35:10 -0800 Message-ID: <20151107003510.GR6114@lukather> References: <1446214865-3972-1-git-send-email-maxime.ripard@free-electrons.com> <1446214865-3972-12-git-send-email-maxime.ripard@free-electrons.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dUQzTuC3g77BtMOt" Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jonathan Liu Cc: Mike Turquette , Stephen Boyd , David Airlie , Thierry Reding , devicetree , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Laurent Pinchart , Chen-Yu Tsai , Hans de Goede , Alexander Kaplan , Wynter Woods , Boris Brezillon , Thomas Petazzoni , Rob Clark , Daniel Vetter List-Id: devicetree@vger.kernel.org --dUQzTuC3g77BtMOt Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Mon, Nov 02, 2015 at 01:53:20PM +1100, Jonathan Liu wrote: > > + ret = sun4i_tv_init(drm); > > + if (ret) { > > + dev_err(drm->dev, "Couldn't create our RGB output\n"); > > RGB should be composite. Seems like a copy-paste error. Good catch. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --dUQzTuC3g77BtMOt--