Re: + memcg-fix-thresholds-for-32b-architectures-fix-fix.patch added to -mm tree

[Sergey Senozhatsky <sergey.senozhatsky@gmail.com>]

Hi,

On (11/05/15 18:31), Andrew Morton wrote:
> > On Tue 03-11-15 15:32:11, Andrew Morton wrote:
> > > From: Andrew Morton <akpm@linux-foundation.org>
> > > Subject: memcg-fix-thresholds-for-32b-architectures-fix-fix
> > > 
> > > don't attempt to inline mem_cgroup_usage()
> > > 
> > > The compiler ignores the inline anwyay.  And __always_inlining it adds 600
> > > bytes of goop to the .o file.
> > 
> > I am not sure you whether you want to fold this into the original patch
> > but I would prefer this to be a separate one.
> 
> I'm going to drop this - it was already marked inline and gcc just
> ignores the inline anyway so shrug.
> 

Just out of curiosity, seems that my gcc (5.2) is happy to inline
it (as of linux-next-20151106):

$ grep 'mem_cgroup_usage ' __ipa_build_log
  Inlining page_counter_read into mem_cgroup_usage (always_inline).
  Inlining page_counter_read into mem_cgroup_usage (always_inline).
  Inlining mem_cgroup_is_root into mem_cgroup_usage (always_inline).
  Inlining mem_cgroup_usage into mem_cgroup_read_u64 (always_inline).
  Inlining mem_cgroup_usage into mem_cgroup_read_u64 (always_inline).
  Inlining mem_cgroup_usage into __mem_cgroup_threshold (always_inline).
  Inlining mem_cgroup_usage into __mem_cgroup_usage_unregister_event (always_inline).
  Inlining mem_cgroup_usage into __mem_cgroup_usage_unregister_event (always_inline).
  Inlining mem_cgroup_usage into __mem_cgroup_usage_register_event (always_inline).
  Inlining mem_cgroup_usage into __mem_cgroup_usage_register_event (always_inline).


and the resulting vmlinux.o files

$ ./scripts/bloat-o-meter vmlinux.o.old vmlinux.o
add/remove: 1/0 grow/shrink: 0/4 up/down: 113/-351 (-238)
function                                     old     new   delta
mem_cgroup_usage                               -     113    +113
__mem_cgroup_usage_unregister_event          409     331     -78
__mem_cgroup_threshold                       529     447     -82
__mem_cgroup_usage_register_event            498     403     -95
mem_cgroup_read_u64                          256     160     -96

	-ss

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>