From: Jens Axboe <axboe@kernel.dk>
To: Matthew Eaton <m.eaton82@gmail.com>
Cc: fio@vger.kernel.org
Subject: Re: Increasing startup time
Date: Sat, 7 Nov 2015 17:29:11 -0700 [thread overview]
Message-ID: <20151108002911.GB9335@kernel.dk> (raw)
In-Reply-To: <CAF+0mvkVOvpqUHRLO_mBXt7UFMFYJMQWH0Au1wssZHa5V=THVA@mail.gmail.com>
On Thu, Nov 05 2015, Matthew Eaton wrote:
> I noticed during testing recent fio releases it seemed bit laggy to
> start, so I tried some tests and it seems fio has been increasingly
> taking longer to start for some reason. Don't know if this is
> expected or if something is wrong?
Try the below.
diff --git a/smalloc.c b/smalloc.c
index 8412e7518464..ce64d6b73df6 100644
--- a/smalloc.c
+++ b/smalloc.c
@@ -213,7 +213,6 @@ static int add_pool(struct pool *pool, unsigned int alloc_size)
if (ptr == MAP_FAILED)
goto out_fail;
- memset(ptr, 0, alloc_size);
pool->map = ptr;
pool->bitmap = (void *) ptr + (pool->nr_blocks * SMALLOC_BPL);
--
Jens Axboe
next prev parent reply other threads:[~2015-11-08 0:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 3:08 Increasing startup time Matthew Eaton
2015-11-08 0:29 ` Jens Axboe [this message]
2015-11-08 0:34 ` Jens Axboe
2015-11-09 17:33 ` Matthew Eaton
2015-11-09 17:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151108002911.GB9335@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=m.eaton82@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.