From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/9] block: Fixes for bdrv_drain
Date: Mon, 9 Nov 2015 21:15:34 +0800 [thread overview]
Message-ID: <20151109131534.GC18363@ad.usersys.redhat.com> (raw)
In-Reply-To: <20151109114220.GD5968@stefanha-x1.localdomain>
On Mon, 11/09 11:42, Stefan Hajnoczi wrote:
> On Mon, Nov 09, 2015 at 10:56:39AM +0800, Fam Zheng wrote:
> > v3: Don't reuse coroutine in bdrv_aio_ioctl. [Stefan]
> > Recursely call .bdrv_drain callback only. [Stefan, Paolo]
>
> I don't understand this change. I thought you want .bdrv_drain() to be
> called on the whole tree, but the latest code seems to call it on the
> root and children only. It doesn't recurse the only the root and first
> level of the tree get .bdrv_drain() calls. Is this intentional?
Right, v4 posted, please ignore this.
prev parent reply other threads:[~2015-11-09 13:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 2:56 [Qemu-devel] [PATCH v3 0/9] block: Fixes for bdrv_drain Fam Zheng
2015-11-09 2:56 ` [Qemu-devel] [PATCH v3 1/9] block: Add more types for tracked request Fam Zheng
2015-11-09 2:56 ` [Qemu-devel] [PATCH v3 2/9] block: Track flush requests Fam Zheng
2015-11-09 2:56 ` [Qemu-devel] [PATCH v3 3/9] block: Track discard requests Fam Zheng
2015-11-09 2:56 ` [Qemu-devel] [PATCH v3 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl Fam Zheng
2015-11-09 2:56 ` [Qemu-devel] [PATCH v3 5/9] block: Add ioctl parameter fields to BlockRequest Fam Zheng
2015-11-09 2:56 ` [Qemu-devel] [PATCH v3 6/9] block: Emulate bdrv_ioctl with bdrv_aio_ioctl and track both Fam Zheng
2015-11-09 2:56 ` [Qemu-devel] [PATCH v3 7/9] block: Drop BlockDriver.bdrv_ioctl Fam Zheng
2015-11-09 2:56 ` [Qemu-devel] [PATCH v3 8/9] block: Introduce BlockDriver.bdrv_drain callback Fam Zheng
2015-11-09 9:24 ` Paolo Bonzini
2015-11-09 9:38 ` Fam Zheng
2015-11-09 2:56 ` [Qemu-devel] [PATCH v3 9/9] qed: Implement .bdrv_drain Fam Zheng
2015-11-09 11:42 ` [Qemu-devel] [PATCH v3 0/9] block: Fixes for bdrv_drain Stefan Hajnoczi
2015-11-09 13:15 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109131534.GC18363@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.