Re: [GIT PULL] MFD for v4.4

[Lee Jones <lee.jones@linaro.org>]

On Mon, 09 Nov 2015, Sudip Mukherjee wrote:

> On Sat, Nov 07, 2015 at 12:42:30PM +0000, Lee Jones wrote:
> > On Fri, 06 Nov 2015, Linus Torvalds wrote:
> > 
> > > On Fri, Nov 6, 2015 at 12:04 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > > >
> > > >   git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-for-linus-4.4
> > > 
> > > Ugh.
> > > 
> > > Maintainers, *please* check new warnings you introduce. We don't have
> > > that many compiler warnings in the kernel, you shouldn't be
> > > introducing new ones and not notice.
> > > 
> > > This pull request introduces this silly new warning:
> > > 
> > >     drivers/mfd/rtsx_pcr.c: In function ‘rtsx_pci_set_pull_ctl’:
> > >     drivers/mfd/rtsx_pcr.c:565:6: warning: unused variable ‘err’
> > > [-Wunused-variable]
> > >       int err;
> > >           ^
> > > 
> > > due to commit b158b69a3765 ("mfd: rtsx: Simplify function return
> > > logic") that removes the actual use of the variable, but not the
> > > variable itself.
> > 
> > I thought these were cleaned up.  Apologies for that.
> 
> Yes, Fix was submitted. https://lkml.org/lkml/2015/10/7/301
> 
> I even got your applied message. (https://lkml.org/lkml/2015/10/13/149)

Very odd.

Appologies for this.  I'm still unsure as to excactly what happened.

Thanks for fixing-up though. 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog