From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
eranbe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v1 ib-next 2/3] IB/core: IB/core: Allow legacy verbs through extended interfaces
Date: Tue, 10 Nov 2015 11:21:07 -0700 [thread overview]
Message-ID: <20151110182107.GG12667@obsidianresearch.com> (raw)
In-Reply-To: <1447178410-15360-3-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Tue, Nov 10, 2015 at 08:00:09PM +0200, Eli Cohen wrote:
> When an extended verbs is an extension to a legacy verb, the original
> functionality is preserved. Hence we do not require each hardware driver
> to set the extended capability. This will allow to use the extended verb
> in its simple form with drivers that do not support the extended
> capability.
Can we please get rid of uverbs_cmd_mask and uverbs_ex_cmd_mask ?
The driver should set the function pointers it does not support to
NULL. We don't need the bitmask because we already know the answer.
For performance, I recommend having the core replace the NULL op
pointers from the driver with a stub that returns ENOTSUP, and then
drop all the checking in the fast path.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-10 18:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 18:00 [PATCH v1 ib-next 0/3] IB core uverbs support for leagacy commands Eli Cohen
[not found] ` <1447178410-15360-1-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-10 18:00 ` [PATCH v1 ib-next 1/3] IB/core: Avoid duplicate code Eli Cohen
2015-11-10 18:00 ` [PATCH v1 ib-next 2/3] IB/core: IB/core: Allow legacy verbs through extended interfaces Eli Cohen
[not found] ` <1447178410-15360-3-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-10 18:21 ` Jason Gunthorpe [this message]
[not found] ` <20151110182107.GG12667-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-11-10 19:57 ` Eli Cohen
[not found] ` <20151110195713.GA21849-lgQlq6cFzJSjLWYaRI30zHI+JuX82XLG@public.gmane.org>
2015-11-10 20:11 ` Jason Gunthorpe
2015-11-10 18:00 ` [PATCH v1 ib-next 3/3] IB/core: Modify conditional on ucontext existence Eli Cohen
2015-12-30 8:25 ` [PATCH v1 ib-next 0/3] IB core uverbs support for leagacy commands Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151110182107.GG12667@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=eranbe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.