From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Greg KH
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mitko Haralanov
<mitko.haralanov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v4 5/9] staging/rdma/hfi1: Add function stubs for TID caching
Date: Wed, 11 Nov 2015 12:31:43 +0300 [thread overview]
Message-ID: <20151111093143.GE18797@mwanda> (raw)
In-Reply-To: <20151111061039.GB9594-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
On Wed, Nov 11, 2015 at 01:10:40AM -0500, ira.weiny wrote:
> The original author and I have been going through the code to see what we can
> do. We have identified a couple of other pieces which can be split.
>
> One question. Is it ok to have functionality which is added which is unused in
> a preliminary patch? I believe this is ok as long as the code compiles but I
> just wanted to make sure. While there are different operations added in this
> patch it is broken to not use them as a set. So we need to have a series which
> implement the pieces with a final patch which exposes the set of operations.
>
> Is this acceptable?
Yeah. It's fine. Don't add warnings about unused static functions
though. Also we like to see a user in the same patchset so don't add
infrastructure first and the user code the next year or whatever.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-11 9:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 22:58 [PATCH v4 0/9] staging/rdma/hfi1: Fix bugs and performance issues ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1446245928-12675-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-10-30 22:58 ` [PATCH v4 1/9] staging/rdma/hfi1: Remove file pointer macros ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-10-30 22:58 ` [PATCH v4 2/9] staging/rdma/hfi1: Clean up macro indentation ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-10-30 22:58 ` [PATCH v4 3/9] staging/rdma/hfi1: Remove unnecessary include files ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-10-30 22:58 ` [PATCH v4 4/9] staging/rdma/hfi1: Move macros to a common header ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-10-30 22:58 ` [PATCH v4 5/9] staging/rdma/hfi1: Add function stubs for TID caching ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-11-07 1:02 ` Greg KH
[not found] ` <20151107010235.GA24586-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-10 0:11 ` ira.weiny
[not found] ` <20151110001102.GA11150-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-11-10 0:18 ` Greg KH
[not found] ` <20151110001827.GA29500-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-11 6:10 ` ira.weiny
[not found] ` <20151111061039.GB9594-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-11-11 9:31 ` Dan Carpenter [this message]
2015-10-30 22:58 ` [PATCH v4 6/9] staging/rdma/hfi1: Implement Expected Receive " ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1446245928-12675-7-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-07 1:03 ` Greg KH
[not found] ` <20151107010328.GA24617-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-10 0:12 ` ira.weiny
2015-10-30 22:58 ` [PATCH v4 7/9] staging/rdma/hfi1: move hfi1_migrate_qp ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-10-30 22:58 ` [PATCH v4 8/9] staging/rdma/hfi1: Use parallel workqueue for SDMA engines ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-10-30 22:58 ` [PATCH v4 9/9] staging/rdma/hfi: pre-compute sc and sde for RC/UC QPs ira.weiny-ral2JQCrhuEAvxtiuMwx3w
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111093143.GE18797@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mitko.haralanov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.