From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs Date: Wed, 11 Nov 2015 03:28:46 -0800 Message-ID: <20151111112846.GA358@infradead.org> References: <1446654807-6935-1-git-send-email-mchristi@redhat.com> <563A36FC.6010001@sandisk.com> <563A3813.5010604@cs.wisc.edu> <20151107102309.GE12117@infradead.org> <5642F3F4.2060007@cs.wisc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5642F3F4.2060007-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Mike Christie Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, device-mapper development , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org List-Id: dm-devel.ids On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote: > We no longer have the bvec merge functions so the original reason given > in the thread/patch Bart referenced is no longer valid. > > Offlist it was suggested that dropping the argument from submit_bio > might still improve performance, but I modified xfs and dm and did some > testing and did not see anything. > > So the change is not needed, and it would only be done because people > feel it would improve the interface. I would defintively prefer the changed interface, and to me it also looks like it would make your overall patch simpler. If you disagree feel free to keep it as-is for now and I'll do another pass later. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id F13DD1055F58 for ; Wed, 11 Nov 2015 12:28:52 +0100 (CET) Date: Wed, 11 Nov 2015 03:28:46 -0800 From: Christoph Hellwig To: Mike Christie Message-ID: <20151111112846.GA358@infradead.org> References: <1446654807-6935-1-git-send-email-mchristi@redhat.com> <563A36FC.6010001@sandisk.com> <563A3813.5010604@cs.wisc.edu> <20151107102309.GE12117@infradead.org> <5642F3F4.2060007@cs.wisc.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5642F3F4.2060007@cs.wisc.edu> Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, device-mapper development , linux-fsdevel@vger.kernel.org, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote: > We no longer have the bvec merge functions so the original reason given > in the thread/patch Bart referenced is no longer valid. > > Offlist it was suggested that dropping the argument from submit_bio > might still improve performance, but I modified xfs and dm and did some > testing and did not see anything. > > So the change is not needed, and it would only be done because people > feel it would improve the interface. I would defintively prefer the changed interface, and to me it also looks like it would make your overall patch simpler. If you disagree feel free to keep it as-is for now and I'll do another pass later. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194AbbKKL2w (ORCPT ); Wed, 11 Nov 2015 06:28:52 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:42236 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751069AbbKKL2u (ORCPT ); Wed, 11 Nov 2015 06:28:50 -0500 Date: Wed, 11 Nov 2015 03:28:46 -0800 From: Christoph Hellwig To: Mike Christie Cc: device-mapper development , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, Bart Van Assche , drbd-dev@lists.linbit.com Subject: Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs Message-ID: <20151111112846.GA358@infradead.org> References: <1446654807-6935-1-git-send-email-mchristi@redhat.com> <563A36FC.6010001@sandisk.com> <563A3813.5010604@cs.wisc.edu> <20151107102309.GE12117@infradead.org> <5642F3F4.2060007@cs.wisc.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5642F3F4.2060007@cs.wisc.edu> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote: > We no longer have the bvec merge functions so the original reason given > in the thread/patch Bart referenced is no longer valid. > > Offlist it was suggested that dropping the argument from submit_bio > might still improve performance, but I modified xfs and dm and did some > testing and did not see anything. > > So the change is not needed, and it would only be done because people > feel it would improve the interface. I would defintively prefer the changed interface, and to me it also looks like it would make your overall patch simpler. If you disagree feel free to keep it as-is for now and I'll do another pass later.