From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers Date: Wed, 11 Nov 2015 17:29:54 +0200 Message-ID: <20151111152954.GH4023@leon.nu> References: <1447220077-8325-1-git-send-email-ira.weiny@intel.com> <20151111062535.GG4023@leon.nu> <20151111133907.GA21044@phlsvsds.ph.intel.com> Reply-To: leon-2ukJVAZIZ/Y@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151111133907.GA21044-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dennis Dalessandro Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, Nov 11, 2015 at 08:39:08AM -0500, Dennis Dalessandro wrote: > On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: > >On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > >>From: Dennis Dalessandro > >> > >>+int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps, > >>+ u64 pbc) > >> { > >>- pr_alert("Snooping/Capture of Send DMA Packets Is Not Supported!\n"); > >>+ pr_alert("Snooping/Capture of Send DMA Packets Is Not Supported!\n"); > >> snoop_dbg("Unsupported Operation"); > >Is it really necessary to do both print alert to message log (pr_alert) and to > >trace buffer (snoop_dbg)? > > Well yes, and no. They serve two different purposes. One for users of the > snoop feature the other for developers. > > However, I don't think we really even need to keep this function around > anymore. How about we just remove it in a follow on patch, and let this one > stand as is? Sure, I'm fine with that. > > -Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html