From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] libnet:new package
Date: Wed, 11 Nov 2015 15:39:26 +0100 [thread overview]
Message-ID: <20151111153926.6543a4a0@free-electrons.com> (raw)
In-Reply-To: <5643507F.3050903@mind.be>
Arnout,
On Wed, 11 Nov 2015 15:28:15 +0100, Arnout Vandecappelle wrote:
> Don't you have a hook that does that automatically? Anyway, they currently are
> still marked as Changes Requested, so I'll update them to Accepted.
I don't use an automatic hook, no. I used to have one, but it wasn't
working well when the patch was changed compared to the one in
patchwork. I know Peter now uses git notes to solve this problem, but I
haven't implemented a similar solution.
Since when I'm done with a patch I anyway have to look again at the
list of patches to pick the next one to work on, it's not a big deal to
mark as Accepted the patch(es) I just applied.
> > This package is not fetched from github. But I've added the hash
> > nonetheless.
>
> Oops, I confused the two patches :-)
As I said to my reply to Joris, there is in fact a newer upstream for
libnet, hosted at github. But it did not build nicely out of the box,
so I gave up and reverted back to the version used by Joris.
> > I did a test build here for ARM, and did not encounter any issues.
> > Which configuration did you test? Or is it just by inspection of
> > configure.ac?
>
> With "fail" I mean that it will think that PF_PACKET/ETH_P_ALL is not
> available, while normally on Linux it is available (at least for root). Maybe
> you can configure it out of the kernel, but that would be a very exotic config.
>
> I noticed it by inspecting configure.ac and tested an armv7 build to confirm.
Right. Can you submit a patch doing that? Either you or Joris?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-11-11 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 9:03 [Buildroot] [PATCH 1/2] libnet:new package Joris Lijssens
2015-11-09 9:03 ` [Buildroot] [PATCH 2/2] netsniff-ng:new package Joris Lijssens
2015-11-11 0:04 ` Arnout Vandecappelle
2015-11-11 14:07 ` Thomas Petazzoni
2015-11-10 23:17 ` [Buildroot] [PATCH 1/2] libnet:new package Arnout Vandecappelle
2015-11-11 14:05 ` Thomas Petazzoni
2015-11-11 14:28 ` Arnout Vandecappelle
2015-11-11 14:39 ` Thomas Petazzoni [this message]
2015-11-11 14:03 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111153926.6543a4a0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.