From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbbKKTis (ORCPT ); Wed, 11 Nov 2015 14:38:48 -0500 Received: from mga11.intel.com ([192.55.52.93]:15067 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbbKKTir (ORCPT ); Wed, 11 Nov 2015 14:38:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,277,1444719600"; d="scan'208";a="598476726" Date: Wed, 11 Nov 2015 11:38:46 -0800 From: "Luck, Tony" To: "Chen, Gong" Cc: bp@alien8.de, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Cleanup useless codes in CMCI handler Message-ID: <20151111193845.GA9055@agluck-desk.sc.intel.com> References: <1447255005-15887-1-git-send-email-gong.chen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447255005-15887-1-git-send-email-gong.chen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2015 at 10:16:45AM -0500, Chen, Gong wrote: > UCNA errors share the same handler with CMCI. But it doesn't > need extra operation to save error record in genpool. Remove > these uselss codes. I'd have emphasised that this same mce is being added to the genpool *twice* (once here, and again when we call mce_log() just below). Though there may be some corner cases depending on flags and mca_cfg.dont_log_ce -Tony > > Signed-off-by: Chen, Gong > --- > arch/x86/kernel/cpu/mcheck/mce.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c > index c5b0d562dbf5..1ad3fb4f99b7 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce.c > +++ b/arch/x86/kernel/cpu/mcheck/mce.c > @@ -609,20 +609,6 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b) > severity = mce_severity(&m, mca_cfg.tolerant, NULL, false); > > /* > - * In the cases where we don't have a valid address after all, > - * do not add it into the ring buffer. > - */ > - if (severity == MCE_DEFERRED_SEVERITY && memory_error(&m)) { > - if (m.status & MCI_STATUS_ADDRV) { > - m.severity = severity; > - m.usable_addr = mce_usable_address(&m); > - > - if (!mce_gen_pool_add(&m)) > - mce_schedule_work(); > - } > - } > - > - /* > * Don't get the IP here because it's unlikely to > * have anything to do with the actual error location. > */ > -- > 2.3.2 >