Re: [PATCH mtd-utils 00/11] flash_{un,}lock upgrades

[Brian Norris <computersforpeace@gmail.com>]

On Mon, Aug 31, 2015 at 03:34:21PM -0700, Brian Norris wrote:
> Hi,
> 
> I've done a bit of work to make the flash_lock tool more useful, in order to
> help test some new SPI NOR block protection features. Of note:
> 
>  * added getopt support
>  * further unified flash_unlock and flash_lock -- the only difference now is
>    their default feature, and both binaries contain support for all features
>  * add support for MEMISLOCKED, so we can query arbitrary regions for
>    protection status
>  * mtdinfo -M already can dump some block lock information, but you get a
>    little more flexibility using flash_lock --info, so both seem worth having
>    IMO
> 
> Unsolved issues:
> 
>  * the MEM{LOCK,UNLOCK,ISLOCKED} ioctls all still use the out-dated 32-bit
>    erase_info_user struct, which means they'll have problems supporting >=4GB
>    flash. This isn't a mtd-utils problem, per se, and at the moment, Linux NAND
>    (the only (?) candidate for >=4GB flash) support doesn't implement any of
>    the locking APIs. But just an observation I ran across.
>  * Deprecation plan: it would make sense to deprecate and remove flash_unlock
>    eventually (in favor of 'flash_lock --unlock'), but this isn't really
>    pressing, so I don't see a good reason to spend much effort on it.
> 
> Enjoy,
> Brian

Pushed to mtd-utils.git