Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] spapr: Register and handle HCALL to receive updated RTAS region

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2142 bytes --]

On Thu, Nov 12, 2015 at 10:58:59AM +0530, Nikunj A Dadhania wrote:
> David Gibson <david@gibson.dropbear.id.au> writes:
> 
> > On Wed, Nov 11, 2015 at 10:45:30PM +0530, Aravinda Prasad wrote:
> >> Receive updates from SLOF about the updated rtas-base.
> >> A separate patch for SLOF [1] adds functionality to invoke
> >> a private HCALL whenever OS issues instantiate-rtas with
> >> a new rtas-base.
> >> 
> >> This is required as QEMU needs to know the updated rtas-base
> >> as it allocates error reporting structure in RTAS space upon
> >> a machine check exception.
> >> 
> >> [1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-August/120386.html
> >> 
> >> Signed-off-by: Aravinda Prasad <aravinda@linux.vnet.ibm.com>
> >
> > Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> >
> > With the obvious proviso that the SLOF update needs to be merged (both
> > to SLOF and to qemu) first.
> 
> The patch is already part of SLOF tree and is there in qemu:
> 
> commit f9a60de30492863811c2cdf6f28988c9e8a2c3d9
> Author: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
> Date:   Mon Aug 25 18:30:10 2014 +0530
> 
>     Add private HCALL to inform updated RTAS base and entry
>     
>     This patch adds a private HCALL to inform qemu the updated
>     rtas-base and rtas-entry address when OS invokes the call
>     "instantiate-rtas". This is required as qemu allocates the
>     error reporting structure in RTAS space upon a machine check
>     exception and hence needs to know the updated RTAS.
>     
>     Enhancements to qemu to handle the private HCALL, prepare
>     error log and invoke machine check notification routine
>     are in a separate patch.
>     
>     Signed-off-by: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
>     Signed-off-by: Aravinda Prasad <aravinda@linux.vnet.ibm.com>
>     Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>

Ah, ok.  Thanks.
-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]