Re: [PATCH 4/5] x86: dumpstack - implement show_stack_lvl()

[Ingo Molnar <mingo@kernel.org>]

* aris@redhat.com <aris@redhat.com> wrote:

> show_stack_lvl() allows passing the log level and is used by dump_stack_lvl().
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Greg Thelen <gthelen@google.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: David Rientjes <rientjes@google.com>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
> 
> ---
>  arch/x86/kernel/dumpstack.c |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.orig/arch/x86/kernel/dumpstack.c	2015-11-05 13:33:30.994378877 -0500
> +++ linux-2.6/arch/x86/kernel/dumpstack.c	2015-11-05 13:44:37.014856773 -0500
> @@ -180,7 +180,7 @@ void show_trace(struct task_struct *task
>  	show_trace_log_lvl(task, regs, stack, bp, "");
>  }
>  
> -void show_stack(struct task_struct *task, unsigned long *sp)
> +void show_stack_lvl(struct task_struct *task, unsigned long *sp, char *log_lvl)
>  {
>  	unsigned long bp = 0;
>  	unsigned long stack;
> @@ -194,7 +194,12 @@ unsigned long bp = 0;
>  		bp = stack_frame(current, NULL);
>  	}
>  
> -	show_stack_log_lvl(task, NULL, sp, bp, "");
> +	show_stack_log_lvl(task, NULL, sp, bp, log_lvl);
> +}
> +
> +void show_stack(struct task_struct *task, unsigned long *sp)
> +{
> +	show_stack_lvl(task, sp, KERN_DEFAULT);
>  }
>  
>  static arch_spinlock_t die_lock = __ARCH_SPIN_LOCK_UNLOCKED;

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>