From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/7] ether: don't mark input multicast for deprecation Date: Thu, 12 Nov 2015 14:10:53 -0800 Message-ID: <20151112141053.5f2f9bba@xeon-e3> References: <1446771879-3979-1-git-send-email-stephen@networkplumber.org> <1446771879-3979-2-git-send-email-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: dev@dpdk.org Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id CF85E924A for ; Thu, 12 Nov 2015 23:10:42 +0100 (CET) Received: by padhx2 with SMTP id hx2so77580333pad.1 for ; Thu, 12 Nov 2015 14:10:42 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id jp1sm14371884pbc.54.2015.11.12.14.10.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2015 14:10:41 -0800 (PST) In-Reply-To: <1446771879-3979-2-git-send-email-stephen@networkplumber.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 5 Nov 2015 17:04:33 -0800 Stephen Hemminger wrote: > The number of received multicast frames is useful and already > available in many/most drivers. Therefore don't mark it as > deprecated. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 1 - > lib/librte_ether/rte_ethdev.h | 3 +-- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index 0b0bbcf..3b71c0c 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2715,7 +2715,6 @@ ixgbevf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > stats->opackets = hw_stats->vfgptc; > stats->obytes = hw_stats->vfgotc; > stats->imcasts = hw_stats->vfmprc; > - /* stats->imcasts should be removed as imcasts is deprecated */ > } > > static void > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 48a540d..f653e37 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -204,8 +204,7 @@ struct rte_eth_stats { > /**< Deprecated; Total of RX packets with bad length. */ > uint64_t ierrors; /**< Total number of erroneous received packets. */ > uint64_t oerrors; /**< Total number of failed transmitted packets. */ > - uint64_t imcasts; > - /**< Deprecated; Total number of multicast received packets. */ > + uint64_t imcasts; /**< Total number of multicast received packets. */ > uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */ > uint64_t fdirmatch; > /**< Deprecated; Total number of RX packets matching a filter. */ I am okay with removing imcasts if all the drivers that support provide the same information in xstats.