From mboxrd@z Thu Jan 1 00:00:00 1970 From: peterz@infradead.org (Peter Zijlstra) Date: Thu, 12 Nov 2015 15:53:31 +0100 Subject: [PATCH] sched/rt: hide push_irq_work_func declaration In-Reply-To: <3810009.VdDTV0h1Qp@wuerfel> References: <3810009.VdDTV0h1Qp@wuerfel> Message-ID: <20151112145331.GC17308@twins.programming.kicks-ass.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Nov 12, 2015 at 03:22:22PM +0100, Arnd Bergmann wrote: > -#ifdef CONFIG_SMP > +#if IS_ENABLED(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > static void push_irq_work_func(struct irq_work *work); > #endif I think we can get tid of the whole HAVE_RT_PUSH_IPI thing after: 8053871d0f7f ("smp: Fix smp_call_function_single_async() locking") That should allow us to use smp_calling_function_single_async() instead of irq_work_queue_on(), removing the dependency on irq_work. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754623AbbKLOxf (ORCPT ); Thu, 12 Nov 2015 09:53:35 -0500 Received: from casper.infradead.org ([85.118.1.10]:43825 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbbKLOxe (ORCPT ); Thu, 12 Nov 2015 09:53:34 -0500 Date: Thu, 12 Nov 2015 15:53:31 +0100 From: Peter Zijlstra To: Arnd Bergmann Cc: Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner Subject: Re: [PATCH] sched/rt: hide push_irq_work_func declaration Message-ID: <20151112145331.GC17308@twins.programming.kicks-ass.net> References: <3810009.VdDTV0h1Qp@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3810009.VdDTV0h1Qp@wuerfel> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2015 at 03:22:22PM +0100, Arnd Bergmann wrote: > -#ifdef CONFIG_SMP > +#if IS_ENABLED(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > static void push_irq_work_func(struct irq_work *work); > #endif I think we can get tid of the whole HAVE_RT_PUSH_IPI thing after: 8053871d0f7f ("smp: Fix smp_call_function_single_async() locking") That should allow us to use smp_calling_function_single_async() instead of irq_work_queue_on(), removing the dependency on irq_work.