From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zwx66-0006pH-0n for linux-mtd@lists.infradead.org; Thu, 12 Nov 2015 18:59:51 +0000 Received: by pacdm15 with SMTP id dm15so72925356pac.3 for ; Thu, 12 Nov 2015 10:59:29 -0800 (PST) Date: Thu, 12 Nov 2015 10:59:26 -0800 From: Brian Norris To: Heiner Kallweit Cc: linux-mtd@lists.infradead.org, Javier Martinez Canillas , Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown Subject: Re: m25p80: Commit "allow arbitrary OF matching for "jedec, spi-nor"" breaks module autoloading Message-ID: <20151112185926.GC8456@google.com> References: <56104E88.3040807@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56104E88.3040807@gmail.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , + others On Sat, Oct 03, 2015 at 11:54:16PM +0200, Heiner Kallweit wrote: > Seems like commit 43163022927b6e7d202a7e6f939c3f392465494d > (allow arbitrary OF matching for "jedec,spi-nor") broke autoloading > of the m25p80 module. > MODALIAS is "spi:spi-nor" and removing "spi-nor" as device alias > prevents module autoloading. > > Of course we could revert the removal of the "spi-nor" device alias. > However it might be better to switch to DT-based matching for > DT-configured devices. > > Adding a call to of_device_uevent_modalias to spi_uevent in spi.c > solved the issue for me, drawback however is that just the first > "compatible" value is used as modalias. In case of m25p80 this means > that "jedec,spi-nor" has to be the first "compatible" value. > This constraint might be too strict .. > > Having said that I'm not sure what could be a better way to fix > the issue than just re-introducing the "spi-nor" device alias. Is this [1] getting fixed in SPI any time soon? Looks like there was some progress [2], but AFAICT it's not completed. I'd just like to know what the way forward here should be for m25p80. Really, "jedec,spi-nor" never autoloaded modules very reliably because of the SPI core constaints. So I'm not sure I'd consider this a regression, and I might be OK waiting around if it'll be fixed in a reasonable time frame. FWIW, I can do testing if somebody's tackling this still. Just CC me. Regards, Brian [1] https://lkml.org/lkml/2014/9/11/458 [2] https://lkml.org/lkml/2015/8/20/109 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading Date: Thu, 12 Nov 2015 10:59:26 -0800 Message-ID: <20151112185926.GC8456@google.com> References: <56104E88.3040807@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Javier Martinez Canillas , Dmitry Torokhov , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown To: Heiner Kallweit Return-path: Content-Disposition: inline In-Reply-To: <56104E88.3040807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: + others On Sat, Oct 03, 2015 at 11:54:16PM +0200, Heiner Kallweit wrote: > Seems like commit 43163022927b6e7d202a7e6f939c3f392465494d > (allow arbitrary OF matching for "jedec,spi-nor") broke autoloading > of the m25p80 module. > MODALIAS is "spi:spi-nor" and removing "spi-nor" as device alias > prevents module autoloading. > > Of course we could revert the removal of the "spi-nor" device alias. > However it might be better to switch to DT-based matching for > DT-configured devices. > > Adding a call to of_device_uevent_modalias to spi_uevent in spi.c > solved the issue for me, drawback however is that just the first > "compatible" value is used as modalias. In case of m25p80 this means > that "jedec,spi-nor" has to be the first "compatible" value. > This constraint might be too strict .. > > Having said that I'm not sure what could be a better way to fix > the issue than just re-introducing the "spi-nor" device alias. Is this [1] getting fixed in SPI any time soon? Looks like there was some progress [2], but AFAICT it's not completed. I'd just like to know what the way forward here should be for m25p80. Really, "jedec,spi-nor" never autoloaded modules very reliably because of the SPI core constaints. So I'm not sure I'd consider this a regression, and I might be OK waiting around if it'll be fixed in a reasonable time frame. FWIW, I can do testing if somebody's tackling this still. Just CC me. Regards, Brian [1] https://lkml.org/lkml/2014/9/11/458 [2] https://lkml.org/lkml/2015/8/20/109 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754397AbbKLS7e (ORCPT ); Thu, 12 Nov 2015 13:59:34 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33664 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565AbbKLS7a (ORCPT ); Thu, 12 Nov 2015 13:59:30 -0500 Date: Thu, 12 Nov 2015 10:59:26 -0800 From: Brian Norris To: Heiner Kallweit Cc: linux-mtd@lists.infradead.org, Javier Martinez Canillas , Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown Subject: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading Message-ID: <20151112185926.GC8456@google.com> References: <56104E88.3040807@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56104E88.3040807@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + others On Sat, Oct 03, 2015 at 11:54:16PM +0200, Heiner Kallweit wrote: > Seems like commit 43163022927b6e7d202a7e6f939c3f392465494d > (allow arbitrary OF matching for "jedec,spi-nor") broke autoloading > of the m25p80 module. > MODALIAS is "spi:spi-nor" and removing "spi-nor" as device alias > prevents module autoloading. > > Of course we could revert the removal of the "spi-nor" device alias. > However it might be better to switch to DT-based matching for > DT-configured devices. > > Adding a call to of_device_uevent_modalias to spi_uevent in spi.c > solved the issue for me, drawback however is that just the first > "compatible" value is used as modalias. In case of m25p80 this means > that "jedec,spi-nor" has to be the first "compatible" value. > This constraint might be too strict .. > > Having said that I'm not sure what could be a better way to fix > the issue than just re-introducing the "spi-nor" device alias. Is this [1] getting fixed in SPI any time soon? Looks like there was some progress [2], but AFAICT it's not completed. I'd just like to know what the way forward here should be for m25p80. Really, "jedec,spi-nor" never autoloaded modules very reliably because of the SPI core constaints. So I'm not sure I'd consider this a regression, and I might be OK waiting around if it'll be fixed in a reasonable time frame. FWIW, I can do testing if somebody's tackling this still. Just CC me. Regards, Brian [1] https://lkml.org/lkml/2014/9/11/458 [2] https://lkml.org/lkml/2015/8/20/109