From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Subject: Re: [PATCH v3 01/17] mm: support madvise(MADV_FREE) Date: Fri, 13 Nov 2015 15:17:19 +0900 Message-ID: <20151113061719.GC5235@bbox> References: <1447302793-5376-1-git-send-email-minchan@kernel.org> <1447302793-5376-2-git-send-email-minchan@kernel.org> <20151112112620.GB22481@node.shutemov.name> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: In-Reply-To: <20151112112620.GB22481-sVvlyX1904swdBt8bTSxpkEMvNT87kid@public.gmane.org> Content-Disposition: inline Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Michael Kerrisk , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hugh Dickins , Johannes Weiner , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Jason Evans , Daniel Micay , Shaohua Li , Michal Hocko , yalin.wang2010-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: linux-api@vger.kernel.org On Thu, Nov 12, 2015 at 01:26:20PM +0200, Kirill A. Shutemov wrote: > On Thu, Nov 12, 2015 at 01:32:57PM +0900, Minchan Kim wrote: > > @@ -256,6 +260,125 @@ static long madvise_willneed(struct vm_area_struct *vma, > > return 0; > > } > > > > +static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > > + unsigned long end, struct mm_walk *walk) > > + > > +{ > > + struct mmu_gather *tlb = walk->private; > > + struct mm_struct *mm = tlb->mm; > > + struct vm_area_struct *vma = walk->vma; > > + spinlock_t *ptl; > > + pte_t *pte, ptent; > > + struct page *page; > > + > > + split_huge_page_pmd(vma, addr, pmd); > > + if (pmd_trans_unstable(pmd)) > > + return 0; > > + > > + pte = pte_offset_map_lock(mm, pmd, addr, &ptl); > > + arch_enter_lazy_mmu_mode(); > > + for (; addr != end; pte++, addr += PAGE_SIZE) { > > + ptent = *pte; > > + > > + if (!pte_present(ptent)) > > + continue; > > + > > + page = vm_normal_page(vma, addr, ptent); > > + if (!page) > > + continue; > > + > > + if (PageSwapCache(page)) { > > Could you put VM_BUG_ON_PAGE(PageTransCompound(page), page) here? > Just in case. No problem. > > > + if (!trylock_page(page)) > > + continue; > > + > > + if (!try_to_free_swap(page)) { > > + unlock_page(page); > > + continue; > > + } > > + > > + ClearPageDirty(page); > > + unlock_page(page); > > Hm. Do we handle pages shared over fork() here? > Souldn't we ignore pages with mapcount > 0? It was handled later patch by historical reason but it's better to fold the patch to this. Thanks for review! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by kanga.kvack.org (Postfix) with ESMTP id 8589E6B0038 for ; Fri, 13 Nov 2015 01:16:51 -0500 (EST) Received: by pabfh17 with SMTP id fh17so90274781pab.0 for ; Thu, 12 Nov 2015 22:16:51 -0800 (PST) Received: from lgeamrelo12.lge.com (LGEAMRELO12.lge.com. [156.147.23.52]) by mx.google.com with ESMTPS id rz10si25153979pab.205.2015.11.12.22.16.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Nov 2015 22:16:50 -0800 (PST) Date: Fri, 13 Nov 2015 15:17:19 +0900 From: Minchan Kim Subject: Re: [PATCH v3 01/17] mm: support madvise(MADV_FREE) Message-ID: <20151113061719.GC5235@bbox> References: <1447302793-5376-1-git-send-email-minchan@kernel.org> <1447302793-5376-2-git-send-email-minchan@kernel.org> <20151112112620.GB22481@node.shutemov.name> MIME-Version: 1.0 In-Reply-To: <20151112112620.GB22481@node.shutemov.name> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , linux-api@vger.kernel.org, Hugh Dickins , Johannes Weiner , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Jason Evans , Daniel Micay , Shaohua Li , Michal Hocko , yalin.wang2010@gmail.com On Thu, Nov 12, 2015 at 01:26:20PM +0200, Kirill A. Shutemov wrote: > On Thu, Nov 12, 2015 at 01:32:57PM +0900, Minchan Kim wrote: > > @@ -256,6 +260,125 @@ static long madvise_willneed(struct vm_area_struct *vma, > > return 0; > > } > > > > +static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > > + unsigned long end, struct mm_walk *walk) > > + > > +{ > > + struct mmu_gather *tlb = walk->private; > > + struct mm_struct *mm = tlb->mm; > > + struct vm_area_struct *vma = walk->vma; > > + spinlock_t *ptl; > > + pte_t *pte, ptent; > > + struct page *page; > > + > > + split_huge_page_pmd(vma, addr, pmd); > > + if (pmd_trans_unstable(pmd)) > > + return 0; > > + > > + pte = pte_offset_map_lock(mm, pmd, addr, &ptl); > > + arch_enter_lazy_mmu_mode(); > > + for (; addr != end; pte++, addr += PAGE_SIZE) { > > + ptent = *pte; > > + > > + if (!pte_present(ptent)) > > + continue; > > + > > + page = vm_normal_page(vma, addr, ptent); > > + if (!page) > > + continue; > > + > > + if (PageSwapCache(page)) { > > Could you put VM_BUG_ON_PAGE(PageTransCompound(page), page) here? > Just in case. No problem. > > > + if (!trylock_page(page)) > > + continue; > > + > > + if (!try_to_free_swap(page)) { > > + unlock_page(page); > > + continue; > > + } > > + > > + ClearPageDirty(page); > > + unlock_page(page); > > Hm. Do we handle pages shared over fork() here? > Souldn't we ignore pages with mapcount > 0? It was handled later patch by historical reason but it's better to fold the patch to this. Thanks for review! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287AbbKMGQv (ORCPT ); Fri, 13 Nov 2015 01:16:51 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:49388 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbbKMGQu (ORCPT ); Fri, 13 Nov 2015 01:16:50 -0500 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.76 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Fri, 13 Nov 2015 15:17:19 +0900 From: Minchan Kim To: "Kirill A. Shutemov" CC: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , linux-api@vger.kernel.org, Hugh Dickins , Johannes Weiner , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Jason Evans , Daniel Micay , Shaohua Li , Michal Hocko , yalin.wang2010@gmail.com Subject: Re: [PATCH v3 01/17] mm: support madvise(MADV_FREE) Message-ID: <20151113061719.GC5235@bbox> References: <1447302793-5376-1-git-send-email-minchan@kernel.org> <1447302793-5376-2-git-send-email-minchan@kernel.org> <20151112112620.GB22481@node.shutemov.name> MIME-Version: 1.0 In-Reply-To: <20151112112620.GB22481@node.shutemov.name> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB03/LGE/LG Group(Release 8.5.3FP3HF583 | August 9, 2013) at 2015/11/13 15:16:45, Serialize by Router on LGEKRMHUB03/LGE/LG Group(Release 8.5.3FP3HF583 | August 9, 2013) at 2015/11/13 15:16:45, Serialize complete at 2015/11/13 15:16:45 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2015 at 01:26:20PM +0200, Kirill A. Shutemov wrote: > On Thu, Nov 12, 2015 at 01:32:57PM +0900, Minchan Kim wrote: > > @@ -256,6 +260,125 @@ static long madvise_willneed(struct vm_area_struct *vma, > > return 0; > > } > > > > +static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > > + unsigned long end, struct mm_walk *walk) > > + > > +{ > > + struct mmu_gather *tlb = walk->private; > > + struct mm_struct *mm = tlb->mm; > > + struct vm_area_struct *vma = walk->vma; > > + spinlock_t *ptl; > > + pte_t *pte, ptent; > > + struct page *page; > > + > > + split_huge_page_pmd(vma, addr, pmd); > > + if (pmd_trans_unstable(pmd)) > > + return 0; > > + > > + pte = pte_offset_map_lock(mm, pmd, addr, &ptl); > > + arch_enter_lazy_mmu_mode(); > > + for (; addr != end; pte++, addr += PAGE_SIZE) { > > + ptent = *pte; > > + > > + if (!pte_present(ptent)) > > + continue; > > + > > + page = vm_normal_page(vma, addr, ptent); > > + if (!page) > > + continue; > > + > > + if (PageSwapCache(page)) { > > Could you put VM_BUG_ON_PAGE(PageTransCompound(page), page) here? > Just in case. No problem. > > > + if (!trylock_page(page)) > > + continue; > > + > > + if (!try_to_free_swap(page)) { > > + unlock_page(page); > > + continue; > > + } > > + > > + ClearPageDirty(page); > > + unlock_page(page); > > Hm. Do we handle pages shared over fork() here? > Souldn't we ignore pages with mapcount > 0? It was handled later patch by historical reason but it's better to fold the patch to this. Thanks for review!