From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] rte_log.h: display level in logs from RTE_LOG
Date: Fri, 13 Nov 2015 08:41:43 -0800
Message-ID: <20151113084143.509908b0@xeon-e3>
References: <1447393802-25736-1-git-send-email-mhall@mhcomputing.net>
 <5645E16D.50601@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id C8ED395DE
 for <dev@dpdk.org>; Fri, 13 Nov 2015 17:41:32 +0100 (CET)
Received: by pasz6 with SMTP id z6so108307976pas.2
 for <dev@dpdk.org>; Fri, 13 Nov 2015 08:41:32 -0800 (PST)
In-Reply-To: <5645E16D.50601@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 13 Nov 2015 15:11:09 +0200
Panu Matilainen <pmatilai@redhat.com> wrote:

> On 11/13/2015 07:50 AM, Matthew Hall wrote:
> > Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> > ---
> >   lib/librte_eal/common/include/rte_log.h | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h
> > index ede0dca..be961d0 100644
> > --- a/lib/librte_eal/common/include/rte_log.h
> > +++ b/lib/librte_eal/common/include/rte_log.h
> > @@ -297,10 +297,10 @@ int rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)
> >    *   - 0: Success.
> >    *   - Negative on error.
> >    */
> > -#define RTE_LOG(l, t, ...)					\
> > -	(void)((RTE_LOG_ ## l <= RTE_LOG_LEVEL) ?		\
> > -	 rte_log(RTE_LOG_ ## l,					\
> > -		 RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__) :	\
> > +#define RTE_LOG(l, t, ...)						\
> > +	(void)((RTE_LOG_ ## l <= RTE_LOG_LEVEL) ?			\
> > +	 rte_log(RTE_LOG_ ## l,						\
> > +		 RTE_LOGTYPE_ ## t, # t ": " #l ": " __VA_ARGS__) :	\
> >   	 0)
> >
> >   #ifdef __cplusplus
> >
> 
> +1 for this, makes it much easier to spot the actually important 
> messages from all the other noise. Both visually and programmatically.
> 
> 	- Panu -

-1
This is already done by syslog and friends and adds more cruft to log messages.