From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix powering on with privacy and advertising
Date: Fri, 13 Nov 2015 13:53:32 +0200 [thread overview]
Message-ID: <20151113115332.GA10089@t440s.lan> (raw)
In-Reply-To: <1447360987-4129-1-git-send-email-andrzej.kaczmarek@codecoup.pl>
Hi Andrzej,
On Thu, Nov 12, 2015, Andrzej Kaczmarek wrote:
> In order to enable advertising with privacy enabled, SMP has to be
> registered in order to generate new RPA. During power on, it will be
> registered at the very end which is the reason why advertising is not
> enabled and it's not possible to enable it anymore due to mismatch
> between hci_dev settings and actual controller state.
>
> This fixes this problem by postponing advertising enable after SMP is
> registered in case of power on.
> ---
> net/bluetooth/mgmt.c | 70 ++++++++++++++++++++++++++++++++++++++++------------
> 1 file changed, 54 insertions(+), 16 deletions(-)
Instead of postponing advertising, did you consider simply moving
smp_register() earlier? Wouldn't it be possible to move it to
mgmt_powered() before powered_update_hci() is called?
Johan
next prev parent reply other threads:[~2015-11-13 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 20:43 [PATCH] Bluetooth: Fix powering on with privacy and advertising Andrzej Kaczmarek
2015-11-12 20:43 ` [PATCH] tools/mgmt-tester: Add power on testcase with adv and privacy Andrzej Kaczmarek
2015-11-23 18:52 ` Szymon Janc
2015-11-13 11:53 ` Johan Hedberg [this message]
2015-11-16 8:31 ` [PATCH] Bluetooth: Fix powering on with privacy and advertising Andrzej Kaczmarek
2015-11-16 8:40 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113115332.GA10089@t440s.lan \
--to=johan.hedberg@gmail.com \
--cc=andrzej.kaczmarek@codecoup.pl \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.