All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Ander Conselvan de Oliveira
	<ander.conselvan.de.oliveira@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH maintainer-tools] dim: Remove git commit --amend from dim_apply
Date: Fri, 13 Nov 2015 14:42:54 +0200	[thread overview]
Message-ID: <20151113124254.GV4437@intel.com> (raw)
In-Reply-To: <20151113121659.GR6247@nuc-i3427.alporthouse.com>

On Fri, Nov 13, 2015 at 12:16:59PM +0000, Chris Wilson wrote:
> On Fri, Nov 13, 2015 at 02:05:39PM +0200, Ander Conselvan de Oliveira wrote:
> > Calling git --amend invokes the editor, which will not run if it relies
> > on the terminal for input. So don't do that from dim_apply.
> > 
> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> 
> Presumable the ammend is there for a good reason and removing it keeps
> the state dirty? So maybe --amend --no-edit?

I don't think there's any reason other than Daniel's gvim workflow.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-11-13 12:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 12:05 [PATCH maintainer-tools] dim: Remove git commit --amend from dim_apply Ander Conselvan de Oliveira
2015-11-13 12:16 ` Chris Wilson
2015-11-13 12:31   ` Tvrtko Ursulin
2015-11-13 14:40     ` Ander Conselvan De Oliveira
2015-11-13 15:07       ` Tvrtko Ursulin
2015-11-13 15:11         ` Ander Conselvan De Oliveira
2015-11-18 15:51           ` Daniel Vetter
2015-11-13 12:33   ` Ander Conselvan De Oliveira
2015-11-13 12:42   ` Ville Syrjälä [this message]
2015-11-13 14:33     ` Jani Nikula
2015-11-13 14:42       ` Ville Syrjälä
2015-11-13 15:05       ` [PATCH maintainer-tools] dim: Replace git commit --amend from dim_apply with dimrc option Ander Conselvan de Oliveira
2015-11-13 15:34         ` Lukas Wunner
2015-11-13 15:36         ` Jani Nikula
2015-11-16 10:17           ` [PATCH v2 " Ander Conselvan de Oliveira
2015-11-18 15:52             ` Daniel Vetter
2015-11-19  8:22               ` Ander Conselvan De Oliveira
2018-12-17 14:49 ` ✗ Fi.CI.BAT: failure for dim: Remove git commit --amend from dim_apply Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151113124254.GV4437@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=ander.conselvan.de.oliveira@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.