From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/4] PSR Critical fixes
Date: Fri, 13 Nov 2015 17:08:57 +0200 [thread overview]
Message-ID: <20151113150857.GY4437@intel.com> (raw)
In-Reply-To: <1447270630-5121-1-git-send-email-rodrigo.vivi@intel.com>
On Wed, Nov 11, 2015 at 11:37:06AM -0800, Rodrigo Vivi wrote:
> Let's split critical PSR fixes from the series that contains other
> reworks, stabilization and improvements.
>
> The second patch in this series isn't considered critical in terms
> of functionality, but it depends on the first one and it can be consider
> a fix for PSR residency on VLV/CHV.
FYI I recently glanced at the psr code and a few things that left me
scratching my head:
- hsw_psr_enable_sink() frobs at the AUX registers without holding the hw_mutex.
On SKL+ it seems to use the normal AUX registers here. Before it used
the special PSR registers, so that may have been OK, but the SKL+
thing seems rather questionable.
- intel_psr_enable() calls intel_psr_activate() on SKL+ but not on
HSW/BDW. I'm thinking there should be a comment there to make it clear
why, if it's even correct.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-13 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 19:37 [PATCH 0/4] PSR Critical fixes Rodrigo Vivi
2015-11-11 19:37 ` [PATCH 1/4] drm/i915: Delay first PSR activation Rodrigo Vivi
2015-11-12 13:50 ` R, Durgadoss
2015-11-12 21:38 ` Vivi, Rodrigo
2015-11-13 9:09 ` R, Durgadoss
2015-11-13 18:45 ` Vivi, Rodrigo
2015-11-11 19:37 ` [PATCH 2/4] drm/i915: Reduce PSR re-activation time for VLV/CHV Rodrigo Vivi
2015-11-11 19:37 ` [PATCH 3/4] drm/i915: PSR: Don't Skip aux handshake on DP_PSR_NO_TRAIN_ON_EXIT Rodrigo Vivi
2015-11-11 19:37 ` [PATCH 4/4] drm/i915: Send TP1 TP2/3 even when panel claims no NO_TRAIN_ON_EXIT Rodrigo Vivi
2015-11-12 13:55 ` [PATCH 0/4] PSR Critical fixes R, Durgadoss
2015-11-13 15:08 ` Ville Syrjälä [this message]
2015-11-13 18:42 ` Vivi, Rodrigo
2015-11-16 16:00 ` Rodrigo Vivi
2015-11-18 14:57 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113150857.GY4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.