From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Anjali Menon <cse.anjalimenon@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: aim-cdev: Used "==" instead of assignment
Date: Sat, 14 Nov 2015 12:38:15 +0530 [thread overview]
Message-ID: <20151114070815.GD3685@sudip-pc> (raw)
In-Reply-To: <1447475230-3678-1-git-send-email-cse.anjalimenon@gmail.com>
On Sat, Nov 14, 2015 at 09:57:10AM +0530, Anjali Menon wrote:
> Used double equal sign instead of equal to sign in the if condition
> to remove the error detected by checkpatch.pl.
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
> drivers/staging/staging/drivers/staging/most/aim-cdev/cdev.c | 2 +-
something wrong with your tree. This path doesnot exist.
But in any case, i think the patch is wrong. wait_event_interruptible()
is executed when most_get_mbo() returns NULL. so if you do
mbo == most_get_mbo() it will immediately come out of sleep as the
condition is true. I think here the intention was to sleep as long as
most_get_mbo() returns NULL. And when it returns a valid pointer it is
saved in mbo variable so that it can be used later in copy_from_user().
regards
sudip
prev parent reply other threads:[~2015-11-14 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 4:27 [PATCH] staging: most: aim-cdev: Used "==" instead of assignment Anjali Menon
2015-11-14 7:08 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151114070815.GD3685@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=cse.anjalimenon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.