All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Mathieu Rondonneau <mathieu_rondonneau@hotmail.com>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai] [PATCH] IPIPE patch for BCM2709/RPI2.
Date: Sat, 14 Nov 2015 19:26:03 +0100	[thread overview]
Message-ID: <20151114182603.GS1820@hermes.click-hack.org> (raw)
In-Reply-To: <BLU437-SMTP2BEF9B6C71BB45D72DA0EF0100@phx.gbl>

On Sat, Nov 14, 2015 at 08:11:52AM -0800, Mathieu Rondonneau wrote:
> On 15-11-14 04:39 AM, Gilles Chanteperdrix wrote:
> > On Fri, Nov 13, 2015 at 09:31:23PM -0800, Mathieu Rondonneau wrote:
> >>  #ifdef CONFIG_OF
> >> @@ -333,6 +349,10 @@ static struct irq_chip armctrl_chip = {
> >>  	.irq_mask = armctrl_mask_irq,
> >>  	.irq_unmask = armctrl_unmask_irq,
> >>  	.irq_set_wake = armctrl_set_wake,
> >> +#ifdef CONFIG_IPIPE
> >> +	.irq_hold = armctrl_mask_irq,
> >> +	.irq_release = armctrl_unmask_irq,
> >> +#endif
> > 
> > Also, as explained during your lengthy discussion, you do not need
> > to define irq_hold and irq_release here.
> > 
> Kernel does not boot if I remove them (also explained in our lengthy
> discussion). I think that's the part we did not understood each other.
> I am happy to remove them if there is another workaround to get the
> kernel booting.

I can not find the mail where you explain what happens when you
remove it. Could you explain it again, please?

Regards.

-- 
					    Gilles.
https://click-hack.org


  reply	other threads:[~2015-11-14 18:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14  5:31 [Xenomai] [PATCH] IPIPE patch for BCM2709/RPI2 Mathieu Rondonneau
2015-11-14  5:38 ` Gilles Chanteperdrix
2015-11-14  6:06   ` Mathieu Rondonneau
2015-11-14  7:16     ` Gilles Chanteperdrix
2015-11-14 16:12       ` Mathieu Rondonneau
2015-11-14  7:15 ` Gilles Chanteperdrix
2015-11-15  1:03   ` Mathieu Rondonneau
2015-11-14 12:39 ` Gilles Chanteperdrix
2015-11-14 16:11   ` Mathieu Rondonneau
2015-11-14 18:26     ` Gilles Chanteperdrix [this message]
2015-11-15  0:14       ` Mathieu Rondonneau
2015-11-15 18:43         ` Gilles Chanteperdrix
2015-11-15 22:21           ` Mathieu Rondonneau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151114182603.GS1820@hermes.click-hack.org \
    --to=gilles.chanteperdrix@xenomai.org \
    --cc=mathieu_rondonneau@hotmail.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.