From: Pavel Machek <pavel@ucw.cz>
To: Saurabh Sengar <saurabh.truth@gmail.com>
Cc: rjw@rjwysocki.net, len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] PM / suspend: replacing printk
Date: Sat, 14 Nov 2015 21:29:02 +0100 [thread overview]
Message-ID: <20151114202902.GD20429@amd> (raw)
In-Reply-To: <1446002641-3052-1-git-send-email-saurabh.truth@gmail.com>
On Wed 2015-10-28 08:54:01, Saurabh Sengar wrote:
> replacing printk(s) with appropriate pr_info and pr_err
> in order to fix checkpatch.pl warnings
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
> @@ -245,7 +245,7 @@ static int suspend_test(int level)
> {
> #ifdef CONFIG_PM_DEBUG
> if (pm_test_level == level) {
> - printk(KERN_INFO "suspend debug: Waiting for %d second(s).\n",
> + pr_info("suspend debug: Waiting for %d second(s).\n",
> pm_test_delay);
> mdelay(pm_test_delay * 1000);
> return 1;
> @@ -317,7 +317,7 @@ static int suspend_enter(suspend_state_t state, bool *wakeup)
>
> error = dpm_suspend_late(PMSG_SUSPEND);
> if (error) {
> - printk(KERN_ERR "PM: late suspend of devices failed\n");
> + pr_err("PM: late suspend of devices failed\n");
> goto Platform_finish;
> }
> error = platform_suspend_prepare_late(state);
> @@ -326,7 +326,7 @@ static int suspend_enter(suspend_state_t state, bool *wakeup)
>
> error = dpm_suspend_noirq(PMSG_SUSPEND);
> if (error) {
> - printk(KERN_ERR "PM: noirq suspend of devices failed\n");
> + pr_err("PM: noirq suspend of devices failed\n");
> goto Platform_early_resume;
> }
> error = platform_suspend_prepare_noirq(state);
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-11-14 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 3:24 [PATCH v3] PM / suspend: replacing printk Saurabh Sengar
2015-11-14 20:29 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-28 3:21 Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151114202902.GD20429@amd \
--to=pavel@ucw.cz \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.