Re: [Qemu-devel] [PULL v2 5/7] aio: Introduce aio-epoll.c

[Fam Zheng <famz@redhat.com>]

On Fri, 11/13 18:09, Paolo Bonzini wrote:
> > +static void aio_epoll_update(AioContext *ctx, AioHandler *node, bool is_new)
> > +{
> > +    struct epoll_event event;
> > +    int r;
> > +
> > +    if (!ctx->epoll_enabled) {
> > +        return;
> > +    }
> > +    if (!node->pfd.events) {
> 
> Coverity says that node might have been freed by the time you call
> aio_epoll_update.  You need to pass node->pfd.fd and node->pfd.events by
> value instead, I think, or move the call earlier in aio_set_fd_handler.
> 

Yes, I'll send a patch.

Fam