From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: imx: fix clk_prepare/unprepare usage
Date: Mon, 16 Nov 2015 13:16:25 +0100 [thread overview]
Message-ID: <20151116121625.GD22022@pengutronix.de> (raw)
In-Reply-To: <1447322328-5171-1-git-send-email-marcus.folkesson@gmail.com>
On Thu, Nov 12, 2015 at 10:58:48AM +0100, Marcus Folkesson wrote:
> clk_prepare/unprapare APIs are not allowed in atomic context, so
> move prepare/unprepare to probe/remove and use clk_enable/disable
> instead.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Do you see a problem? I don't claim your patch is wrong, I just wonder
why nobody else noticed it earlier (including me).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-11-16 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 9:58 [PATCH] serial: imx: fix clk_prepare/unprepare usage Marcus Folkesson
2015-11-16 12:16 ` Uwe Kleine-König [this message]
2015-11-16 13:52 ` Marcus Folkesson
2015-11-16 14:11 ` Fabio Estevam
2015-11-16 12:49 ` Fabio Estevam
2015-11-16 14:11 ` Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116121625.GD22022@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.