From: Ralf Baechle <ralf@linux-mips.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] mtd: jz4740_nand: fix build on jz4740 after removing gpio.h
Date: Mon, 16 Nov 2015 14:23:28 +0100 [thread overview]
Message-ID: <20151116132328.GB9425@linux-mips.org> (raw)
In-Reply-To: <1447284976-96693-1-git-send-email-computersforpeace@gmail.com>
On Wed, Nov 11, 2015 at 03:36:16PM -0800, Brian Norris wrote:
> Fallout from commit 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
>
> We see errors like this:
>
> drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_detect_bank':
> drivers/mtd/nand/jz4740_nand.c:340:9: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)
> drivers/mtd/nand/jz4740_nand.c:340:9: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mtd/nand/jz4740_nand.c:359:2: error: implicit declaration of function 'jz_gpio_set_function' [-Werror=implicit-function-declaration]
> drivers/mtd/nand/jz4740_nand.c:359:29: error: 'JZ_GPIO_FUNC_MEM_CS0' undeclared (first use in this function)
> drivers/mtd/nand/jz4740_nand.c:399:29: error: 'JZ_GPIO_FUNC_NONE' undeclared (first use in this function)
> drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_probe':
> drivers/mtd/nand/jz4740_nand.c:528:13: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)
> drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_remove':
> drivers/mtd/nand/jz4740_nand.c:555:14: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)
>
> Patched similarly to:
>
> https://patchwork.linux-mips.org/patch/11089/
>
> Fixes: 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Looks, good, shall I funnel this upstream?
Ralf
next prev parent reply other threads:[~2015-11-16 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 23:36 [PATCH] mtd: jz4740_nand: fix build on jz4740 after removing gpio.h Brian Norris
2015-11-11 23:36 ` Brian Norris
2015-11-16 13:23 ` Ralf Baechle [this message]
2015-11-16 18:49 ` Brian Norris
2015-11-16 19:04 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116132328.GB9425@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=computersforpeace@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.