From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qom: Clean up assertions to display values on failure
Date: Mon, 16 Nov 2015 17:01:01 +0000 [thread overview]
Message-ID: <20151116170101.GG20157@redhat.com> (raw)
In-Reply-To: <1447693029-25683-1-git-send-email-afaerber@suse.de>
On Mon, Nov 16, 2015 at 05:57:09PM +0100, Andreas Färber wrote:
> Instead of using g_assert() for integer comparisons, use
> g_assert_cmpint() so that we can see the respective values.
>
> While at it, fix one stray indentation.
>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
prev parent reply other threads:[~2015-11-16 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 16:57 [Qemu-devel] [PATCH] qom: Clean up assertions to display values on failure Andreas Färber
2015-11-16 17:01 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116170101.GG20157@redhat.com \
--to=berrange@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.