All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [conntrackd PATCH v3] conntrackd: add systemd support
Date: Mon, 16 Nov 2015 18:03:26 +0100	[thread overview]
Message-ID: <20151116170325.GA1694@salvia> (raw)
In-Reply-To: <CAOkSjBgG7pVyP1LT0p+cbjrHkTGXRB=KPnrAVNQHSVSXys0xfw@mail.gmail.com>

On Mon, Nov 16, 2015 at 03:22:21PM +0100, Arturo Borrero Gonzalez wrote:
> On 16 November 2015 at 12:17, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Fri, Nov 13, 2015 at 11:59:35AM +0100, Arturo Borrero Gonzalez wrote:
> >> v2: change functions definitions to static inline if no BUILD_SYSTEMD,
> >>     and set watchdog variables as static.
> >>
> >> v3: add runtime systemd configuration. Report warnings.
> >
> > One more question:
> >
> > This is checking for 'libsystemd >= 227'
> >
> > Is this library version really required? Or it is simply that you have
> > set to the most recent version for some reason?
> 
> 227 is the version I've tested. Previous versions may not work.
> 
> For example, I remember the library being split in several small
> libraries and then mixed into this libsystemd, thus changing some
> headers and include paths.
> 
> Also, I simply ignore what is the behaviour of the watchdog stuff
> previous to 227, it seems a recent thing.
> 
> What are your concerns?

I would like not to see many ifdefs in the conntrack-tools tree just
because they update interfaces too frequently. Could you check at
their history record to see how they have been performing on that
front so far?

Thanks.

  reply	other threads:[~2015-11-16 17:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 10:59 [conntrackd PATCH v3] conntrackd: add systemd support Arturo Borrero Gonzalez
2015-11-13 11:39 ` Arturo Borrero Gonzalez
2015-11-13 15:54   ` Pablo Neira Ayuso
2015-11-16 10:54     ` Arturo Borrero Gonzalez
2015-11-16 11:31       ` Pablo Neira Ayuso
2015-11-16 11:17 ` Pablo Neira Ayuso
2015-11-16 14:22   ` Arturo Borrero Gonzalez
2015-11-16 17:03     ` Pablo Neira Ayuso [this message]
2015-11-17 10:25       ` Pablo Neira Ayuso
2015-11-18 16:50         ` Arturo Borrero Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151116170325.GA1694@salvia \
    --to=pablo@netfilter.org \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.