From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v5 03/10] xen/blkfront: pseudo support for
 multi hardware queues/rings
Date: Mon, 16 Nov 2015 16:54:54 -0500
Message-ID: <20151116215454.GA14577@char.us.oracle.com>
References: <1447470739-18136-1-git-send-email-bob.liu@oracle.com>
	<1447470739-18136-4-git-send-email-bob.liu@oracle.com>
	<20151116203838.GF25235@char.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20151116203838.GF25235@char.us.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Bob Liu <bob.liu@oracle.com>
Cc: jonathan.davies@citrix.com, felipe.franciosi@citrix.com, rafal.mielniczuk@citrix.com, linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, axboe@fb.com, david.vrabel@citrix.com, avanzini.arianna@gmail.com, roger.pau@citrix.com
List-Id: xen-devel@lists.xenproject.org

> -       for (i = 0; i < info->nr_rings; i++)
> +       for (i = 0; i < info->nr_rings; i++) {
>                 blkif_free_ring(&info->rinfo[i]);
> -       kfree(info->rinfo);
> +               kfree(info->rinfo);
> +               info->ring = NULL;
> +       }

Duh! Not it shouldn't. That is because we do info->ring = kzalloc(.. * info->nr_rings)).

<sigh> That throws me off every time.