From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 1/2] libxl: replace libxl__sprintf(gc,
	...) with GCSPRINTF
Date: Tue, 17 Nov 2015 15:16:18 +0000
Message-ID: <20151117151618.GD1495@citrix.com>
References: <1447772928-12652-1-git-send-email-wei.liu2@citrix.com>
	<1447772928-12652-2-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7567c56b2=wei.liu2@citrix.com>)
	id 1Zyi04-000818-D7
	for xen-devel@lists.xenproject.org; Tue, 17 Nov 2015 15:16:52 +0000
Content-Disposition: inline
In-Reply-To: <1447772928-12652-2-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Nov 17, 2015 at 03:08:47PM +0000, Wei Liu wrote:
> The rune is
> 
>   sed -i 's/libxl__sprintf(gc,\s*\(".*",.*\)/GCSPRINTF(\1/g' libxl*.c
> 

Hmm... It looks like this rune alone doesn't cover all situations.

 $ ack-grep 'libxl__sprintf\(gc' | wc -l 
 43

Let me see if I can refine it a bit or use multiple runes to replace all
libxl__sprintf.