From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZyiAm-0002tT-6F
	for qemu-devel@nongnu.org; Tue, 17 Nov 2015 10:28:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZyiAi-0001MX-HC
	for qemu-devel@nongnu.org; Tue, 17 Nov 2015 10:27:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50532)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZyiAi-0001MQ-Bo
	for qemu-devel@nongnu.org; Tue, 17 Nov 2015 10:27:52 -0500
Date: Tue, 17 Nov 2015 15:27:47 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20151117152747.GJ14972@redhat.com>
References: <1444739866-14798-1-git-send-email-berrange@redhat.com>
	<1444739866-14798-2-git-send-email-berrange@redhat.com>
	<87lh9wodgd.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87lh9wodgd.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH v4 1/7] qom: introduce
 ObjectPropertyIterator struct for iteration
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

On Tue, Nov 17, 2015 at 04:25:22PM +0100, Markus Armbruster wrote:
> I apologize for the lateness of my review.

> > +void object_property_iter_free(ObjectPropertyIterator *iter)
> > +{
> > +    if (!iter) {
> > +        return;
> > +    }
> > +    g_free(iter);
> 
> g_free(NULL) is perfectly safe; please drop the conditional.

The next patch in the series has to free some fields in 'iter'
so the check for NULL upfront is not redundant.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|