From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH v2 02/11] mm: add pmd_mkclean() Date: Tue, 17 Nov 2015 10:52:43 -0700 Message-ID: <20151117175243.GA28024@linux.intel.com> References: <1447459610-14259-1-git-send-email-ross.zwisler@linux.intel.com> <1447459610-14259-3-git-send-email-ross.zwisler@linux.intel.com> <56468838.6010506@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ross Zwisler , linux-kernel@vger.kernel.org, "H. Peter Anvin" , "J. Bruce Fields" , Theodore Ts'o , Alexander Viro , Andreas Dilger , Dan Williams , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, x86@kernel.org, xfs@oss.sgi.com, Andrew Morton , Matthew Wilcox To: Dave Hansen Return-path: Content-Disposition: inline In-Reply-To: <56468838.6010506@intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-ext4.vger.kernel.org On Fri, Nov 13, 2015 at 05:02:48PM -0800, Dave Hansen wrote: > On 11/13/2015 04:06 PM, Ross Zwisler wrote: > > +static inline pmd_t pmd_mkclean(pmd_t pmd) > > +{ > > + return pmd_clear_flags(pmd, _PAGE_DIRTY | _PAGE_SOFT_DIRTY); > > +} > > pte_mkclean() doesn't clear _PAGE_SOFT_DIRTY. What the thought behind > doing it here? I just wrote it to undo the work done by pmd_mkdirty() - you're right, it should mirror the work done by pte_mkclean() and not clear _PAGE_SOFT_DIRTY. I'll fix this for v3, thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id DF4917F37 for ; Tue, 17 Nov 2015 11:52:47 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 68182AC003 for ; Tue, 17 Nov 2015 09:52:47 -0800 (PST) Received: from mga14.intel.com ([192.55.52.115]) by cuda.sgi.com with ESMTP id G5iAywO6neFVpbMP for ; Tue, 17 Nov 2015 09:52:45 -0800 (PST) Date: Tue, 17 Nov 2015 10:52:43 -0700 From: Ross Zwisler Subject: Re: [PATCH v2 02/11] mm: add pmd_mkclean() Message-ID: <20151117175243.GA28024@linux.intel.com> References: <1447459610-14259-1-git-send-email-ross.zwisler@linux.intel.com> <1447459610-14259-3-git-send-email-ross.zwisler@linux.intel.com> <56468838.6010506@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56468838.6010506@intel.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Hansen Cc: "J. Bruce Fields" , linux-mm@kvack.org, Andreas Dilger , "H. Peter Anvin" , Jeff Layton , Dan Williams , linux-nvdimm@lists.01.org, x86@kernel.org, Ingo Molnar , Matthew Wilcox , Ross Zwisler , linux-ext4@vger.kernel.org, xfs@oss.sgi.com, Alexander Viro , Thomas Gleixner , Theodore Ts'o , linux-kernel@vger.kernel.org, Jan Kara , linux-fsdevel@vger.kernel.org, Andrew Morton , Matthew Wilcox On Fri, Nov 13, 2015 at 05:02:48PM -0800, Dave Hansen wrote: > On 11/13/2015 04:06 PM, Ross Zwisler wrote: > > +static inline pmd_t pmd_mkclean(pmd_t pmd) > > +{ > > + return pmd_clear_flags(pmd, _PAGE_DIRTY | _PAGE_SOFT_DIRTY); > > +} > > pte_mkclean() doesn't clear _PAGE_SOFT_DIRTY. What the thought behind > doing it here? I just wrote it to undo the work done by pmd_mkdirty() - you're right, it should mirror the work done by pte_mkclean() and not clear _PAGE_SOFT_DIRTY. I'll fix this for v3, thanks! _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754421AbbKQRws (ORCPT ); Tue, 17 Nov 2015 12:52:48 -0500 Received: from mga14.intel.com ([192.55.52.115]:39268 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800AbbKQRwp (ORCPT ); Tue, 17 Nov 2015 12:52:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,308,1444719600"; d="scan'208";a="822360638" Date: Tue, 17 Nov 2015 10:52:43 -0700 From: Ross Zwisler To: Dave Hansen Cc: Ross Zwisler , linux-kernel@vger.kernel.org, "H. Peter Anvin" , "J. Bruce Fields" , "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Dan Williams , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@ml01.01.org, x86@kernel.org, xfs@oss.sgi.com, Andrew Morton , Matthew Wilcox Subject: Re: [PATCH v2 02/11] mm: add pmd_mkclean() Message-ID: <20151117175243.GA28024@linux.intel.com> Mail-Followup-To: Ross Zwisler , Dave Hansen , linux-kernel@vger.kernel.org, "H. Peter Anvin" , "J. Bruce Fields" , Theodore Ts'o , Alexander Viro , Andreas Dilger , Dan Williams , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, x86@kernel.org, xfs@oss.sgi.com, Andrew Morton , Matthew Wilcox References: <1447459610-14259-1-git-send-email-ross.zwisler@linux.intel.com> <1447459610-14259-3-git-send-email-ross.zwisler@linux.intel.com> <56468838.6010506@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56468838.6010506@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2015 at 05:02:48PM -0800, Dave Hansen wrote: > On 11/13/2015 04:06 PM, Ross Zwisler wrote: > > +static inline pmd_t pmd_mkclean(pmd_t pmd) > > +{ > > + return pmd_clear_flags(pmd, _PAGE_DIRTY | _PAGE_SOFT_DIRTY); > > +} > > pte_mkclean() doesn't clear _PAGE_SOFT_DIRTY. What the thought behind > doing it here? I just wrote it to undo the work done by pmd_mkdirty() - you're right, it should mirror the work done by pte_mkclean() and not clear _PAGE_SOFT_DIRTY. I'll fix this for v3, thanks!