From: Christoph Hellwig <hch@infradead.org>
To: "Casper Ti. Vector" <caspervector@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 1/2] linux_reboot.h: support 1-argument reboot() from alternative libc.
Date: Tue, 17 Nov 2015 13:04:43 -0800 [thread overview]
Message-ID: <20151117210443.GA31873@infradead.org> (raw)
In-Reply-To: <3122dea1b0bbfab174b9e1cc70aec72676568f52.1447762216.git.CasperVector@gmail.com>
On Tue, Nov 17, 2015 at 04:54:15PM +0800, Casper Ti. Vector wrote:
> Original code assumes 1-argument reboot() is only provided by glibc 2.x
> and later; but as far as the patch author knows, at least the following
> alternative C libraries for linux also provide the 1-argument variant:
>
> * uclibc: all public releases.
> * dietlibc: 0.7.2 and all later releases; reboot() was not provided in
> 0.7.1 and earlier versions.
> * musl: all public releases.
> * klibc: all public releases.
> * bionic: all public releases.
>
> ... which should already cover most use cases.
Or rather all useful cases. I'd say remove the old version
entirely and the wrappers entirely.
next prev parent reply other threads:[~2015-11-17 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 8:54 [PATCH 1/2] linux_reboot.h: support 1-argument reboot() from alternative libc Casper Ti. Vector
2015-11-17 9:05 ` [PATCH 2/2] linux_reboot.h: remove code that is unused anyway Casper Ti. Vector
2015-11-17 21:04 ` Christoph Hellwig [this message]
2015-11-18 12:59 ` [PATCH 1/2] linux_reboot.h: support 1-argument reboot() from alternative libc Karel Zak
2015-11-19 2:52 ` [PATCH v2 1/2] ctrlaltdel: use reboot() provided by libc, assuming it is 1-adic Casper Ti. Vector
2015-11-19 11:12 ` Karel Zak
2015-11-19 11:38 ` Casper Ti. Vector
2015-11-19 2:56 ` [PATCH v2 2/2] Remove now useless linux_reboot.h Casper Ti. Vector
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117210443.GA31873@infradead.org \
--to=hch@infradead.org \
--cc=caspervector@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.