From mboxrd@z Thu Jan  1 00:00:00 1970
From: Borislav Petkov <bp@alien8.de>
Subject: Re: [RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping
 calculation
Date: Wed, 18 Nov 2015 12:28:46 +0100
Message-ID: <20151118112846.GD4138@pd.tnic>
References: <1447497436-26424-1-git-send-email-bp@alien8.de>
 <1447497436-26424-2-git-send-email-bp@alien8.de>
 <564C5C90.3080903@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
	KVM <kvm@vger.kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <564C5C90.3080903@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Wed, Nov 18, 2015 at 12:10:08PM +0100, Paolo Bonzini wrote:
> On 14/11/2015 11:37, Borislav Petkov wrote:
> >  	vendor = x86_vendor();
> > -	family = x86_family();
> > +	family = x86_family_cpuid();
> 
> What about renaming x86_vendor() so that this looks like
> 
> -	vendor = x86_vendor();
> -	family = x86_family();
> +	vendor = x86_cpuid_vendor();
> +	family = x86_cpuid_family();

The idea is that x86_family_cpuid() gives the family *after* having
executed CPUID while x86_family() only computes the family from a
supplied CPUID_1_EAX. I.e., the last saves us the CPUID call.

Hmm, maybe I should make that more clear ...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.