From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [net PATCH] i40e/i40evf: avoid mutex re-init
Date: Wed, 18 Nov 2015 15:12:47 -0800 [thread overview]
Message-ID: <20151118151247.00002b0d@unknown> (raw)
In-Reply-To: <1447869701-3883-1-git-send-email-jesse.brandeburg@intel.com>
On Wed, 18 Nov 2015 10:01:41 -0800
Jesse Brandeburg <jesse.brandeburg@intel.com> wrote:
> If the driver were to happen to have a mutex held while
> the i40e_init_adminq call was called, the init_adminq might
> inadvertently call mutex_init on a lock that was held
> which is a violation of the calling semantics.
>
> Fix this by avoiding adminq.c code allocating/freeing this memory, and
> then do the same work only once in probe/remove.
>
> Testing Hints (Required if no HSD): for VF, load i40evf in bare metal
> and echo 32 > sriov_numvfs; echo 0 > sriov_numvfs in a loop. Yes this
> is a horrible thing to do.
>
> Reported-by: Stefan Assmann <sassmann@redhat.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Change-ID: Ida263c51b34e195252179e7e5e400d73a99be7a2
This patch has a bug, v2 will be sent.
prev parent reply other threads:[~2015-11-18 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 18:01 [Intel-wired-lan] [net PATCH] i40e/i40evf: avoid mutex re-init Jesse Brandeburg
2015-11-18 23:12 ` Jesse Brandeburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118151247.00002b0d@unknown \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.