All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Rajat Jain <rajatxjain@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
	Davide Libenzi <davidel@xmailserver.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Anonymous inode cleanup?
Date: Wed, 18 Nov 2015 21:24:27 +0000	[thread overview]
Message-ID: <20151118212427.GF22011@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAA93t1rJzGD8xed_5uLboPHos+dPrj5XVXebbORz7P9LKwi-0Q@mail.gmail.com>

On Wed, Nov 18, 2015 at 01:10:10PM -0800, Rajat Jain wrote:
> I see reference taken for the path and module in anon_inode_getfile()
> 
> Don't I need to drop that, or would fput() do it for me?
> 
>         path_put(&path);

        dput(dentry);
        mntput(mnt);
in the very end of __fput()

>         module_put(fops->owner);

        fops_put(file->f_op);
slightly earlier in the same function.

  reply	other threads:[~2015-11-18 21:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13  5:43 Anonymous inode cleanup? Rajat Jain
2015-11-13  5:52 ` Mateusz Guzik
2015-11-13  6:31 ` Al Viro
2015-11-18 20:28   ` Rajat Jain
2015-11-18 21:06     ` Al Viro
2015-11-18 21:10       ` Rajat Jain
2015-11-18 21:24         ` Al Viro [this message]
2015-11-18 21:25           ` Rajat Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151118212427.GF22011@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=davidel@xmailserver.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rajatxjain@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.