From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 0/3] Fix and cleanup for 32-bit PV sysexit Date: Thu, 19 Nov 2015 13:10:44 +0100 Message-ID: <20151119121044.GD5953@pd.tnic> References: <1447877179-2775-1-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1447877179-2775-1-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Boris Ostrovsky Cc: konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, mingo@redhat.com, david.vrabel@citrix.com, luto@kernel.org, hpa@zytor.com, xen-devel@lists.xenproject.org, tglx@linutronix.de List-Id: virtualization@lists.linuxfoundation.org T24gV2VkLCBOb3YgMTgsIDIwMTUgYXQgMDM6MDY6MTZQTSAtMDUwMCwgQm9yaXMgT3N0cm92c2t5 IHdyb3RlOgo+IFRoZSBmaXJzdCBwYXRjaCBmaXhlcyBYZW4gUFYgcmVncmVzc2lvbiBpbnRyb2R1 Y2VkIGJ5IDMyLWJpdCByZXdyaXRlLiBVbmxpa2UgdGhlCj4gZWFybGllciB2ZXJzaW9uIGl0IHVz ZXMgQUxURVJOQVRJVkUgaW5zdHJ1Y3Rpb24gYW5kIGF2b2lkcyB1c2luZyB4ZW5fc3lzZXhpdAo+ IChhbmQgc3lzcmV0MzIgaW4gY29tcGF0IG1vZGUpIHB2IG9wcywgYXMgc3VnZ2VzdGVkIGJ5IEFu ZHkuIChJIGVuZGVkIHVwIHBhdGNoaW5nCj4gVEVTVCB3aXRoIFhPUiB0byBhdm9pZCBleHRyYSBO T1BzLCBldmVuIHRob3VnaCBJIHNhaWQgeWVzdGVyZGF5IGl0IHdvdWxkIGJlCj4gd3JvbmcuIEl0 J3Mgbm90IHdyb25nKQo+IAo+IEFzIHJlc3VsdCBvZiB0aGlzIHBhdGNoIGlycV9lbmFibGVfc3lz ZXhpdCBhbmQgdXNlcmdzX3N5c3JldDMyIHB2IG9wcyBhcmUgbm90Cj4gdXNlZCBhbnltb3JlIGJ5 IGFueW9uZSBhbmQgc28gY2FuIGJlIHJlbW92ZWQuCj4gCj4gQm9yaXMgT3N0cm92c2t5ICgzKToK PiAgIHg4Ni94ZW46IEF2b2lkIGZhc3Qgc3lzY2FsbCBwYXRoIGZvciBYZW4gUFYgZ3Vlc3RzCj4g ICB4ODY6IGlycV9lbmFibGVfc3lzZXhpdCBwdiBvcCBpcyBubyBsb25nZXIgbmVlZGVkCj4gICB4 ODY6IHVzZXJnc19zeXNyZXQzMiBwdiBvcCBpcyBubyBsb25nZXIgbmVlZGVkCj4gCj4gIGFyY2gv eDg2L2VudHJ5L2VudHJ5XzMyLlMgICAgICAgICAgICAgfCAxMSArKysrLS0tLS0tLQo+ICBhcmNo L3g4Ni9lbnRyeS9lbnRyeV82NF9jb21wYXQuUyAgICAgIHwgMTYgKysrKysrLS0tLS0tLS0tLQo+ ICBhcmNoL3g4Ni9pbmNsdWRlL2FzbS9jcHVmZWF0dXJlLmggICAgIHwgIDEgKwo+ICBhcmNoL3g4 Ni9pbmNsdWRlL2FzbS9wYXJhdmlydC5oICAgICAgIHwgMTIgLS0tLS0tLS0tLS0tCj4gIGFyY2gv eDg2L2luY2x1ZGUvYXNtL3BhcmF2aXJ0X3R5cGVzLmggfCAxNyAtLS0tLS0tLS0tLS0tLS0tLQo+ ICBhcmNoL3g4Ni9rZXJuZWwvYXNtLW9mZnNldHMuYyAgICAgICAgIHwgIDMgLS0tCj4gIGFyY2gv eDg2L2tlcm5lbC9hc20tb2Zmc2V0c182NC5jICAgICAgfCAgMSAtCj4gIGFyY2gveDg2L2tlcm5l bC9wYXJhdmlydC5jICAgICAgICAgICAgfCAxMiAtLS0tLS0tLS0tLS0KPiAgYXJjaC94ODYva2Vy bmVsL3BhcmF2aXJ0X3BhdGNoXzMyLmMgICB8ICAyIC0tCj4gIGFyY2gveDg2L2tlcm5lbC9wYXJh dmlydF9wYXRjaF82NC5jICAgfCAgMyAtLS0KPiAgYXJjaC94ODYveGVuL2VubGlnaHRlbi5jICAg ICAgICAgICAgICB8ICA3ICsrKy0tLS0KPiAgYXJjaC94ODYveGVuL3hlbi1hc21fMzIuUyAgICAg ICAgICAgICB8IDE0IC0tLS0tLS0tLS0tLS0tCj4gIGFyY2gveDg2L3hlbi94ZW4tYXNtXzY0LlMg ICAgICAgICAgICAgfCAxOSAtLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGFyY2gveDg2L3hlbi94ZW4t b3BzLmggICAgICAgICAgICAgICAgfCAgMyAtLS0KPiAgMTQgZmlsZXMgY2hhbmdlZCwgMTQgaW5z ZXJ0aW9ucygrKSwgMTA3IGRlbGV0aW9ucygtKQoKQ2FuJ3QgYXJndWUgd2l0aCB0aGF0IGRpZmZz dGF0IQoKOi0pCgotLSAKUmVnYXJkcy9HcnVzcywKICAgIEJvcmlzLgoKU1VTRSBMaW51eCBHbWJI LCBHRjogRmVsaXggSW1lbmTDtnJmZmVyLCBKYW5lIFNtaXRoYXJkLCBHcmFoYW0gTm9ydG9uLCBI UkIgMjEyODQgKEFHIE7DvHJuYmVyZykKLS0gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXph dGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRh dGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757550AbbKSMK7 (ORCPT ); Thu, 19 Nov 2015 07:10:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:47736 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753022AbbKSMK6 (ORCPT ); Thu, 19 Nov 2015 07:10:58 -0500 Date: Thu, 19 Nov 2015 13:10:44 +0100 From: Borislav Petkov To: Boris Ostrovsky Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, david.vrabel@citrix.com, konrad.wilk@oracle.com, luto@kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 0/3] Fix and cleanup for 32-bit PV sysexit Message-ID: <20151119121044.GD5953@pd.tnic> References: <1447877179-2775-1-git-send-email-boris.ostrovsky@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1447877179-2775-1-git-send-email-boris.ostrovsky@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 18, 2015 at 03:06:16PM -0500, Boris Ostrovsky wrote: > The first patch fixes Xen PV regression introduced by 32-bit rewrite. Unlike the > earlier version it uses ALTERNATIVE instruction and avoids using xen_sysexit > (and sysret32 in compat mode) pv ops, as suggested by Andy. (I ended up patching > TEST with XOR to avoid extra NOPs, even though I said yesterday it would be > wrong. It's not wrong) > > As result of this patch irq_enable_sysexit and usergs_sysret32 pv ops are not > used anymore by anyone and so can be removed. > > Boris Ostrovsky (3): > x86/xen: Avoid fast syscall path for Xen PV guests > x86: irq_enable_sysexit pv op is no longer needed > x86: usergs_sysret32 pv op is no longer needed > > arch/x86/entry/entry_32.S | 11 ++++------- > arch/x86/entry/entry_64_compat.S | 16 ++++++---------- > arch/x86/include/asm/cpufeature.h | 1 + > arch/x86/include/asm/paravirt.h | 12 ------------ > arch/x86/include/asm/paravirt_types.h | 17 ----------------- > arch/x86/kernel/asm-offsets.c | 3 --- > arch/x86/kernel/asm-offsets_64.c | 1 - > arch/x86/kernel/paravirt.c | 12 ------------ > arch/x86/kernel/paravirt_patch_32.c | 2 -- > arch/x86/kernel/paravirt_patch_64.c | 3 --- > arch/x86/xen/enlighten.c | 7 +++---- > arch/x86/xen/xen-asm_32.S | 14 -------------- > arch/x86/xen/xen-asm_64.S | 19 ------------------- > arch/x86/xen/xen-ops.h | 3 --- > 14 files changed, 14 insertions(+), 107 deletions(-) Can't argue with that diffstat! :-) -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --