From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] tools/libxc: Correct XC_DOM_PAGE_SIZE() to
 return a long long
Date: Thu, 19 Nov 2015 16:50:41 +0000
Message-ID: <20151119165041.GB5043@citrix.com>
References: <1447944341-31420-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1447944341-31420-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, Nov 19, 2015 at 02:45:41PM +0000, Andrew Cooper wrote:
> c/s abdf3c5b "libxc: create p2m list outside of kernel mapping if supported"
> introduces a use which Coverity objects to; an int used to mask a uint64_t.
> 
> The result needs to be signed to allow ~XC_DOM_PAGE_SIZE() to function

$ git grep XC_DOM_PAGE_SIZE

tools/libxc/include/xc_dom.h:#define XC_DOM_PAGE_SIZE(dom)   (1 << (dom)->arch_hooks
tools/libxc/include/xc_dom.h:    unsigned int page_size = XC_DOM_PAGE_SIZE(dom);
tools/libxc/xc_dom_core.c:    unsigned int page_size = XC_DOM_PAGE_SIZE(dom);
tools/libxc/xc_dom_core.c:    unsigned int page_size = XC_DOM_PAGE_SIZE(dom);
tools/libxc/xc_dom_core.c:    unsigned int page_size = XC_DOM_PAGE_SIZE(dom);
tools/libxc/xc_dom_core.c:    unsigned int page_size = XC_DOM_PAGE_SIZE(dom);
tools/libxc/xc_dom_core.c:    page_size = XC_DOM_PAGE_SIZE(dom);
tools/libxc/xc_dom_core.c:         (dom->parms.p2m_base & (XC_DOM_PAGE_SIZE(dom) - 1
tools/libxc/xc_dom_elfloader.c:    elf->dest_size = pages * XC_DOM_PAGE_SIZE(dom);
tools/libxc/xc_dom_hvmloader.c:    elf->dest_size = pages * XC_DOM_PAGE_SIZE(dom);
tools/libxc/xc_dom_x86.c:    memset(l3tab, 0, XC_DOM_PAGE_SIZE(dom));

There is no use for ~XC_DOM_PAGE_SIZE.

And what is the possible scenario you want that?

> correctly, and long long to function properly in 32bit builds.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/libxc/include/xc_dom.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/xc_dom.h
> index 6f0c6e0..2176216 100644
> --- a/tools/libxc/include/xc_dom.h
> +++ b/tools/libxc/include/xc_dom.h
> @@ -249,7 +249,7 @@ struct xc_dom_arch {
>  void xc_dom_register_arch_hooks(struct xc_dom_arch *hooks);
>  
>  #define XC_DOM_PAGE_SHIFT(dom)  ((dom)->arch_hooks->page_shift)
> -#define XC_DOM_PAGE_SIZE(dom)   (1 << (dom)->arch_hooks->page_shift)
> +#define XC_DOM_PAGE_SIZE(dom)   (1LL << (dom)->arch_hooks->page_shift)
>  
>  /* --- main functions ---------------------------------------------- */
>  
> -- 
> 2.1.4
>